Skip to content

Conversation

s-barannikov
Copy link
Contributor

Mask operand is likely a copy-past error, they don't have one.

Mask operand is likely a copy-past error, they don't have one.
@llvmbot
Copy link
Member

llvmbot commented Aug 15, 2025

@llvm/pr-subscribers-backend-risc-v

Author: Sergei Barannikov (s-barannikov)

Changes

Mask operand is likely a copy-past error, they don't have one.


Full diff: https://github.com/llvm/llvm-project/pull/153865.diff

1 Files Affected:

  • (modified) llvm/lib/Target/RISCV/RISCVInstrInfoXAndes.td (+1-1)
diff --git a/llvm/lib/Target/RISCV/RISCVInstrInfoXAndes.td b/llvm/lib/Target/RISCV/RISCVInstrInfoXAndes.td
index c75addd95b149..1fb30a0b73d92 100644
--- a/llvm/lib/Target/RISCV/RISCVInstrInfoXAndes.td
+++ b/llvm/lib/Target/RISCV/RISCVInstrInfoXAndes.td
@@ -420,7 +420,7 @@ class NDSRVInstVD4DOT<bits<6> funct6, string opcodestr>
 }
 
 class NDSRVInstVBFHCvt<bits<5> vs1, string opcodestr>
-    : RVInst<(outs VR:$vd), (ins VR:$vs2, VMaskOp:$vm),
+    : RVInst<(outs VR:$vd), (ins VR:$vs2),
              opcodestr, "$vd, $vs2", [], InstFormatR> {
   bits<5> vs2;
   bits<5> vd;

@topperc
Copy link
Collaborator

topperc commented Aug 15, 2025

Is the title missing the word "operand"?

@s-barannikov s-barannikov changed the title [RISCV] Remove non-existent of nds.vfwcvt/nds.vfncvt instructions [RISCV] Remove non-existent operand of nds.vfwcvt/nds.vfncvt instructions Aug 15, 2025
@s-barannikov
Copy link
Contributor Author

Is the title missing the word "operand"?

Fixed :)

@s-barannikov s-barannikov requested a review from tclin914 August 15, 2025 20:37
Copy link
Collaborator

@topperc topperc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@s-barannikov s-barannikov merged commit b7d6f48 into llvm:main Aug 15, 2025
11 checks passed
@s-barannikov s-barannikov deleted the riscv-fix-andes-vfcvt branch August 15, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants