Skip to content

[libc++] Remove UB from std::__tree_node construction #153908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
Sep 11, 2025
Merged

[libc++] Remove UB from std::__tree_node construction #153908

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
2f689f9
use allocator as template arg and allocator_traits, tests passed in c…
vinay-deshmukh Aug 13, 2025
bbc637a
remove UB using list
vinay-deshmukh Aug 16, 2025
99c2829
cf
vinay-deshmukh Aug 16, 2025
5afe3a4
doc-fix
vinay-deshmukh Aug 16, 2025
ca72744
Replace __value_ with __get_value() for __tree_node
vinay-deshmukh Aug 16, 2025
47b71f8
miss typo
vinay-deshmukh Aug 16, 2025
d16fabf
fix ctor for cpp03 buffer
vinay-deshmukh Aug 16, 2025
dcd4cb4
cf
vinay-deshmukh Aug 16, 2025
08f5328
rename in map as well
vinay-deshmukh Aug 16, 2025
4b5609c
cf
vinay-deshmukh Aug 16, 2025
d24dbc2
include
vinay-deshmukh Aug 16, 2025
9c47574
more?
vinay-deshmukh Aug 16, 2025
8b1278e
hide from abi
vinay-deshmukh Aug 16, 2025
b241636
terser
vinay-deshmukh Aug 17, 2025
f5cc9c3
redundant launder
vinay-deshmukh Aug 18, 2025
c1a776e
single branch
vinay-deshmukh Aug 18, 2025
4e905fe
remove the & from buffer
vinay-deshmukh Aug 18, 2025
225b03c
remove _LIBCPP_STANDALONE_DEBUG
vinay-deshmukh Aug 18, 2025
1b01b80
cf
vinay-deshmukh Aug 18, 2025
62df872
Merge remote-tracking branch 'upstream/main' into vinay-issue-128660-…
vinay-deshmukh Aug 19, 2025
e035df9
Merge branch 'main' into vinay-issue-128660-map-ub
vinay-deshmukh Aug 30, 2025
675a0ca
Merge remote-tracking branch 'upstream/main' into vinay-issue-128660-…
vinay-deshmukh Aug 31, 2025
54951dd
Merge branch 'vinay-issue-128660-map-ub' of out:vinay-deshmukh/llvm-p…
vinay-deshmukh Aug 31, 2025
77c1569
Remove ~__tree_node_base() = default;
vinay-deshmukh Sep 1, 2025
0698243
Update __hash_node constructor to be similar to __tree_node
vinay-deshmukh Sep 1, 2025
5cd0195
cf
vinay-deshmukh Sep 1, 2025
881284a
Merge remote-tracking branch 'upstream/main' into vinay-issue-128660-…
vinay-deshmukh Sep 1, 2025
f7332e6
delete ~__tree_node_base
vinay-deshmukh Sep 4, 2025
8e9153e
Revert "delete ~__tree_node_base"
vinay-deshmukh Sep 4, 2025
3ded535
Default to nullptr, and assign __hash during construction
vinay-deshmukh Sep 6, 2025
ccc9292
fix eager reduction...
vinay-deshmukh Sep 7, 2025
a59fb89
format
vinay-deshmukh Sep 7, 2025
117e150
Fix doc comment, to say construct, not allocate
vinay-deshmukh Sep 7, 2025
f0dfc29
After public
vinay-deshmukh Sep 10, 2025
603b60b
Merge remote-tracking branch 'upstream/main' into vinay-issue-128660-…
vinay-deshmukh Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading