RuntimeLibcalls: Use get_host_tool_path for executables used in benchmark

[arsenm]

Copied from what the llvm-shlib build is doing.

This reverts commit 0b1b567.

[arsenm]

• RuntimeLibcalls: Use get_host_tool_path for executables used in benchmark #153955 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[arsenm]

ping

[s-barannikov]

As long as buildbots are happy :) Let's see
I'm not entirely sure how get_host_tool_path works, but looking at other uses it seems it should.

[llvm-ci]

LLVM Buildbot has detected a new failure on builder fuchsia-x86_64-linux running on fuchsia-debian-64-us-central1-a-1 while building llvm at step 4 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/11/builds/24222

Here is the relevant piece of the build log for the reference

Step 4 (annotate) failure: 'python ../llvm-zorg/zorg/buildbot/builders/annotated/fuchsia-linux.py ...' (failure)
...
-- Performing Test HAVE_CXX_FLAG_COVERAGE - Failed
-- Compiling and running to test HAVE_GNU_POSIX_REGEX
-- Performing Test HAVE_GNU_POSIX_REGEX -- failed to compile
-- Compiling and running to test HAVE_POSIX_REGEX
-- Performing Test HAVE_POSIX_REGEX -- success
-- Compiling and running to test HAVE_STEADY_CLOCK
-- Performing Test HAVE_STEADY_CLOCK -- success
-- Compiling and running to test HAVE_PTHREAD_AFFINITY
-- Performing Test HAVE_PTHREAD_AFFINITY -- success
-- Configuring done
CMake Error at benchmarks/CMakeLists.txt:24 (add_custom_command):
  Error evaluating generator expression:

    $<TARGET_FILE:llvm-nm>

  Target "llvm-nm" is not an executable or library.


CMake Error at benchmarks/CMakeLists.txt:24 (add_custom_command):
  Error evaluating generator expression:

    $<TARGET_FILE:llvm-nm>

  Target "llvm-nm" is not an executable or library.


CMake Error at benchmarks/CMakeLists.txt:24 (add_custom_command):
  Error evaluating generator expression:

    $<TARGET_FILE:llvm-nm>

  Target "llvm-nm" is not an executable or library.


-- Generating done
CMake Generate step failed.  Build files cannot be regenerated correctly.
['cmake', '-S', '/var/lib/buildbot/fuchsia-x86_64-linux/build/../llvm-project/llvm', '-B', '/var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-o7b_rf9r', '-G', 'Ninja', '-D', 'LLVM_CCACHE_BUILD=ON', '-D', 'LLVM_ENABLE_LTO=OFF', '-D', 'FUCHSIA_SDK=/usr/local/fuchsia/sdk', '-D', 'LLVM_RUNTIME_MULTILIBS=', '-C', '/var/lib/buildbot/fuchsia-x86_64-linux/build/../llvm-project/clang/cmake/caches/Fuchsia-stage2.cmake'] exited with return code 1.
@@@STEP_FAILURE@@@
@@@BUILD_STEP build@@@
Running: ninja -C /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-o7b_rf9r toolchain-distribution
ninja: Entering directory `/var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-o7b_rf9r'
ninja: error: loading 'build.ninja': No such file or directory
['ninja', '-C', '/var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-o7b_rf9r', 'toolchain-distribution'] exited with return code 1.
@@@STEP_FAILURE@@@
@@@BUILD_STEP check@@@
Running: ninja -C /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-o7b_rf9r check-llvm check-clang check-lld
ninja: Entering directory `/var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-o7b_rf9r'
ninja: error: loading 'build.ninja': No such file or directory
['ninja', '-C', '/var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-o7b_rf9r', 'check-llvm', 'check-clang', 'check-lld'] exited with return code 1.
@@@STEP_FAILURE@@@
Step 5 (configure) failure: configure (failure)
...
-- Performing Test HAVE_CXX_FLAG_WSHORTEN_64_TO_32 - Success
-- Performing Test HAVE_CXX_FLAG_FSTRICT_ALIASING
-- Performing Test HAVE_CXX_FLAG_FSTRICT_ALIASING - Success
-- Performing Test HAVE_CXX_FLAG_WNO_DEPRECATED_DECLARATIONS
-- Performing Test HAVE_CXX_FLAG_WNO_DEPRECATED_DECLARATIONS - Success
-- Performing Test HAVE_CXX_FLAG_FNO_EXCEPTIONS
-- Performing Test HAVE_CXX_FLAG_FNO_EXCEPTIONS - Success
-- Performing Test HAVE_CXX_FLAG_WSTRICT_ALIASING
-- Performing Test HAVE_CXX_FLAG_WSTRICT_ALIASING - Success
-- Performing Test HAVE_CXX_FLAG_WD654
-- Performing Test HAVE_CXX_FLAG_WD654 - Failed
-- Performing Test HAVE_CXX_FLAG_WTHREAD_SAFETY
-- Performing Test HAVE_CXX_FLAG_WTHREAD_SAFETY - Success
-- Enabling additional flags: -DINCLUDE_DIRECTORIES=/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/third-party/benchmark/include
-- Compiling and running to test HAVE_THREAD_SAFETY_ATTRIBUTES
-- Performing Test HAVE_THREAD_SAFETY_ATTRIBUTES -- success
-- Performing Test HAVE_CXX_FLAG_COVERAGE
-- Performing Test HAVE_CXX_FLAG_COVERAGE - Failed
-- Compiling and running to test HAVE_GNU_POSIX_REGEX
-- Performing Test HAVE_GNU_POSIX_REGEX -- failed to compile
-- Compiling and running to test HAVE_POSIX_REGEX
-- Performing Test HAVE_POSIX_REGEX -- success
-- Compiling and running to test HAVE_STEADY_CLOCK
-- Performing Test HAVE_STEADY_CLOCK -- success
-- Compiling and running to test HAVE_PTHREAD_AFFINITY
-- Performing Test HAVE_PTHREAD_AFFINITY -- success
-- Configuring done
CMake Error at benchmarks/CMakeLists.txt:24 (add_custom_command):
  Error evaluating generator expression:

    $<TARGET_FILE:llvm-nm>

  Target "llvm-nm" is not an executable or library.
CMake Error at benchmarks/CMakeLists.txt:24 (add_custom_command):
  Error evaluating generator expression:

    $<TARGET_FILE:llvm-nm>

  Target "llvm-nm" is not an executable or library.


CMake Error at benchmarks/CMakeLists.txt:24 (add_custom_command):
  Error evaluating generator expression:

    $<TARGET_FILE:llvm-nm>

  Target "llvm-nm" is not an executable or library.
-- Generating done
CMake Generate step failed.  Build files cannot be regenerated correctly.
['cmake', '-S', '/var/lib/buildbot/fuchsia-x86_64-linux/build/../llvm-project/llvm', '-B', '/var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-o7b_rf9r', '-G', 'Ninja', '-D', 'LLVM_CCACHE_BUILD=ON', '-D', 'LLVM_ENABLE_LTO=OFF', '-D', 'FUCHSIA_SDK=/usr/local/fuchsia/sdk', '-D', 'LLVM_RUNTIME_MULTILIBS=', '-C', '/var/lib/buildbot/fuchsia-x86_64-linux/build/../llvm-project/clang/cmake/caches/Fuchsia-stage2.cmake'] exited with return code 1.

[s-barannikov]

Perhaps it should be guarded by if (LLVM_BUILD_TOOLS) if (LLVM_INCLUDE_TOOLS)

[arsenm]

Perhaps it should be guarded by if (LLVM_BUILD_TOOLS) if (LLVM_INCLUDE_TOOLS)

In the previous versions I hoped that would be implicit based on the check for the built target, that way it's not dependent on the exact set of build options if they ever change

[s-barannikov]

I think the latest approach is the correct one. IIRC the previous attempts might have tried to execute a cross-built tool.

[arsenm]

Attempt 2 #159489

[brendandahl]

We're seeing failures from this chain of patches in the emscripten toolchain. It doesn't appear any of the follow ups have fixed it either.

CMake Error at benchmarks/CMakeLists.txt:23 (if):
  if given arguments:

    "TARGET" "AND" "TARGET"

  Unknown arguments specified

https://logs.chromium.org/logs/emscripten-releases/buildbucket/cr-buildbucket/8703371298336821617/+/u/Build_LLVM__cross_/stdout