Skip to content

Conversation

bassiounix
Copy link
Contributor

No description provided.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@bassiounix bassiounix marked this pull request as ready for review August 18, 2025 23:17
@llvmbot llvmbot added the libc label Aug 18, 2025
@llvmbot
Copy link
Member

llvmbot commented Aug 18, 2025

@llvm/pr-subscribers-libc

Author: Muhammad Bassiouni (bassiounix)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/154226.diff

1 Files Affected:

  • (modified) libc/src/__support/math/expxf16_utils.h (+1-1)
diff --git a/libc/src/__support/math/expxf16_utils.h b/libc/src/__support/math/expxf16_utils.h
index 651ef12d8a59d..5d3bd3845a74f 100644
--- a/libc/src/__support/math/expxf16_utils.h
+++ b/libc/src/__support/math/expxf16_utils.h
@@ -25,7 +25,7 @@ namespace math {
 
 namespace expxf16_internal {
 
-LIBC_INLINE static constexpr ExpRangeReduction exp2_range_reduction(float16 x) {
+LIBC_INLINE static ExpRangeReduction exp2_range_reduction(float16 x) {
   // For -25 < x < 16, to compute 2^x, we perform the following range reduction:
   // find hi, mid, lo, such that:
   //   x = hi + mid + lo, in which

@bassiounix
Copy link
Contributor Author

@lntue I'm merging this to fix build errors ASAP.

@bassiounix bassiounix merged commit 523c3a0 into main Aug 19, 2025
23 checks passed
@bassiounix bassiounix deleted the users/bassiounix/spr/08-19-_libc_math_fix_coshf16_build_errors branch August 19, 2025 00:39
@lntue
Copy link
Contributor

lntue commented Aug 19, 2025

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants