Skip to content

Conversation

michaelrj-google
Copy link
Contributor

The test added by #150802 was missing a close at the end.

The test added by llvm#150802 was missing a close at the end.
@llvmbot llvmbot added the libc label Aug 19, 2025
@michaelrj-google michaelrj-google requested a review from lntue August 19, 2025 17:19
@llvmbot
Copy link
Member

llvmbot commented Aug 19, 2025

@llvm/pr-subscribers-libc

Author: Michael Jones (michaelrj-google)

Changes

The test added by #150802 was missing a close at the end.


Full diff: https://github.com/llvm/llvm-project/pull/154392.diff

1 Files Affected:

  • (modified) libc/test/src/__support/File/file_test.cpp (+1)
diff --git a/libc/test/src/__support/File/file_test.cpp b/libc/test/src/__support/File/file_test.cpp
index 04ab78b07d04c..17dad4d5ac917 100644
--- a/libc/test/src/__support/File/file_test.cpp
+++ b/libc/test/src/__support/File/file_test.cpp
@@ -510,4 +510,5 @@ TEST(LlvmLibcFileTest, WriteSplit) {
   static constexpr size_t WR_EXPECTED = AVAIL - (sizeof(data) - 1);
   ASSERT_EQ(WR_EXPECTED, f->write(data2, sizeof(data2) - 1).value);
   EXPECT_TRUE(f->error());
+  ASSERT_EQ(f->close(), 0);
 }

@michaelrj-google michaelrj-google merged commit d2b2d6f into llvm:main Aug 19, 2025
21 checks passed
@michaelrj-google michaelrj-google deleted the libcFileTestFix branch August 19, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants