Skip to content

[flang][cuda][NFC] Add getDataAttr helper #154586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clementval merged 2 commits into from
Aug 20, 2025
Merged

[flang][cuda][NFC] Add getDataAttr helper #154586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1dec1e
[flang][cuda][NFC] Add getDataAttr helper
clementval Aug 20, 2025
a483eb1
format
clementval Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions flang/include/flang/Optimizer/Dialect/CUF/Attributes/CUFAttr.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,9 @@ getProcAttribute(mlir::MLIRContext *mlirContext,
return {};
}

/// Returns the data attribute if the operation has one.
cuf::DataAttributeAttr getDataAttr(mlir::Operation *op);

/// Returns true if the operation has a data attribute with the given value.
bool hasDataAttr(mlir::Operation *op, cuf::DataAttribute value);

Expand Down
25 changes: 16 additions & 9 deletions flang/lib/Optimizer/Dialect/CUF/Attributes/CUFAttr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,19 +30,26 @@ void CUFDialect::registerAttributes() {
LaunchBoundsAttr, ProcAttributeAttr>();
}

bool hasDataAttr(mlir::Operation *op, cuf::DataAttribute value) {
cuf::DataAttributeAttr getDataAttr(mlir::Operation *op) {
if (!op)
return false;
return {};

if (auto dataAttr =
op->getAttrOfType<cuf::DataAttributeAttr>(cuf::getDataAttrName()))
return dataAttr;

cuf::DataAttributeAttr dataAttr =
op->getAttrOfType<cuf::DataAttributeAttr>(cuf::getDataAttrName());
// When the attribute is declared on the operation, it doesn't have a prefix.
if (!dataAttr)
dataAttr = op->getAttrOfType<cuf::DataAttributeAttr>(cuf::dataAttrName);
if (!dataAttr)
return false;
if (auto dataAttr =
op->getAttrOfType<cuf::DataAttributeAttr>(cuf::dataAttrName))
return dataAttr;

return dataAttr.getValue() == value;
return {};
}

bool hasDataAttr(mlir::Operation *op, cuf::DataAttribute value) {
if (auto dataAttr = getDataAttr(op))
return dataAttr.getValue() == value;
return false;
}

} // namespace cuf