Skip to content

Conversation

@andykaylor
Copy link
Contributor

This fixes a warning about having a default case in a fully covered enum switch statement.

This fixes a warning about having a default case in a fully covered enum
switch statement.
@llvmbot llvmbot added clang Clang issues not falling into any other category ClangIR Anything related to the ClangIR project labels Aug 20, 2025
@llvmbot
Copy link
Member

llvmbot commented Aug 20, 2025

@llvm/pr-subscribers-clangir

@llvm/pr-subscribers-clang

Author: Andy Kaylor (andykaylor)

Changes

This fixes a warning about having a default case in a fully covered enum switch statement.


Full diff: https://github.com/llvm/llvm-project/pull/154609.diff

1 Files Affected:

  • (modified) clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp (+1-2)
diff --git a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp
index ed5d9b83fc60e..9972d7612105d 100644
--- a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp
+++ b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp
@@ -1181,9 +1181,8 @@ getLLVMMemOrder(std::optional<cir::MemOrder> memorder) {
     return mlir::LLVM::AtomicOrdering::acq_rel;
   case cir::MemOrder::SequentiallyConsistent:
     return mlir::LLVM::AtomicOrdering::seq_cst;
-  default:
-    llvm_unreachable("unknown memory order");
   }
+  llvm_unreachable("unknown memory order");
 }
 
 mlir::LogicalResult CIRToLLVMLoadOpLowering::matchAndRewrite(

@andykaylor andykaylor merged commit 59b3324 into llvm:main Aug 20, 2025
12 checks passed
@andykaylor andykaylor deleted the fix-memorder-warning branch August 20, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clang Clang issues not falling into any other category ClangIR Anything related to the ClangIR project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants