Skip to content

Conversation

@joker-eph
Copy link
Collaborator

No description provided.

@joker-eph joker-eph added the skip-precommit-approval PR for CI feedback, not intended for review label Aug 20, 2025
@joker-eph joker-eph enabled auto-merge (squash) August 20, 2025 21:04
@llvmbot llvmbot added the mlir label Aug 20, 2025
@llvmbot
Copy link
Member

llvmbot commented Aug 20, 2025

@llvm/pr-subscribers-mlir

Author: Mehdi Amini (joker-eph)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/154616.diff

1 Files Affected:

  • (modified) mlir/lib/Conversion/ConvertToLLVM/ConvertToLLVMPass.cpp (+4-3)
diff --git a/mlir/lib/Conversion/ConvertToLLVM/ConvertToLLVMPass.cpp b/mlir/lib/Conversion/ConvertToLLVM/ConvertToLLVMPass.cpp
index cdb715064b0f7..764ad2e766c73 100644
--- a/mlir/lib/Conversion/ConvertToLLVM/ConvertToLLVMPass.cpp
+++ b/mlir/lib/Conversion/ConvertToLLVM/ConvertToLLVMPass.cpp
@@ -14,6 +14,7 @@
 #include "mlir/IR/PatternMatch.h"
 #include "mlir/Rewrite/FrozenRewritePatternSet.h"
 #include "mlir/Transforms/DialectConversion.h"
+#include "llvm/Support/DebugLog.h"
 #include <memory>
 
 #define DEBUG_TYPE "convert-to-llvm"
@@ -79,13 +80,13 @@ class LoadDependentDialectExtension : public DialectExtensionBase {
 
   void apply(MLIRContext *context,
              MutableArrayRef<Dialect *> dialects) const final {
-    LLVM_DEBUG(llvm::dbgs() << "Convert to LLVM extension load\n");
+    LDBG() << "Convert to LLVM extension load";
     for (Dialect *dialect : dialects) {
       auto *iface = dyn_cast<ConvertToLLVMPatternInterface>(dialect);
       if (!iface)
         continue;
-      LLVM_DEBUG(llvm::dbgs() << "Convert to LLVM found dialect interface for "
-                              << dialect->getNamespace() << "\n");
+      LDBG() << "Convert to LLVM found dialect interface for "
+             << dialect->getNamespace();
       iface->loadDependentDialects(context);
     }
   }

@joker-eph joker-eph merged commit 780750b into llvm:main Aug 20, 2025
12 checks passed
rupprecht added a commit to rupprecht/llvm-project that referenced this pull request Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mlir skip-precommit-approval PR for CI feedback, not intended for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants