[Clang][Codegen][NFC] Apply rule of three to some classes #154671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Static analysis flagged these classes as having implemented the destructor but not applying rule of three. This could lead to accidental misuse and so it makes sense to apply it.
shafik
requested review from
AaronBallman,
cor3ntin,
tahonermann and
thurstond
llvmbot
added
clang
Member
|
@llvm/pr-subscribers-clang-codegen @llvm/pr-subscribers-debuginfo Author: Shafik Yaghmour (shafik) ChangesStatic analysis flagged these classes as having implemented the destructor but not applying rule of three. This could lead to accidental misuse and so it makes sense to apply it. Full diff: https://github.com/llvm/llvm-project/pull/154671.diff 1 Files Affected:
diff --git a/clang/lib/CodeGen/CGDebugInfo.h b/clang/lib/CodeGen/CGDebugInfo.h
index 497d3a6ab17b1..ff9c3cd2d1136 100644
--- a/clang/lib/CodeGen/CGDebugInfo.h
+++ b/clang/lib/CodeGen/CGDebugInfo.h
@@ -977,6 +977,8 @@ class ApplyInlineDebugLocation {
ApplyInlineDebugLocation(CodeGenFunction &CGF, GlobalDecl InlinedFn);
/// Restore everything back to the original state.
~ApplyInlineDebugLocation();
+ ApplyInlineDebugLocation(const ApplyInlineDebugLocation &) = delete;
+ ApplyInlineDebugLocation &operator=(ApplyInlineDebugLocation &) = delete;
};
class SanitizerDebugLocation {
@@ -988,6 +990,8 @@ class SanitizerDebugLocation {
ArrayRef<SanitizerKind::SanitizerOrdinal> Ordinals,
SanitizerHandler Handler);
~SanitizerDebugLocation();
+ SanitizerDebugLocation(const SanitizerDebugLocation &) = delete;
+ SanitizerDebugLocation &operator=(SanitizerDebugLocation &) = delete;
};
} // namespace CodeGen
|
Member
|
@llvm/pr-subscribers-clang Author: Shafik Yaghmour (shafik) ChangesStatic analysis flagged these classes as having implemented the destructor but not applying rule of three. This could lead to accidental misuse and so it makes sense to apply it. Full diff: https://github.com/llvm/llvm-project/pull/154671.diff 1 Files Affected:
diff --git a/clang/lib/CodeGen/CGDebugInfo.h b/clang/lib/CodeGen/CGDebugInfo.h
index 497d3a6ab17b1..ff9c3cd2d1136 100644
--- a/clang/lib/CodeGen/CGDebugInfo.h
+++ b/clang/lib/CodeGen/CGDebugInfo.h
@@ -977,6 +977,8 @@ class ApplyInlineDebugLocation {
ApplyInlineDebugLocation(CodeGenFunction &CGF, GlobalDecl InlinedFn);
/// Restore everything back to the original state.
~ApplyInlineDebugLocation();
+ ApplyInlineDebugLocation(const ApplyInlineDebugLocation &) = delete;
+ ApplyInlineDebugLocation &operator=(ApplyInlineDebugLocation &) = delete;
};
class SanitizerDebugLocation {
@@ -988,6 +990,8 @@ class SanitizerDebugLocation {
ArrayRef<SanitizerKind::SanitizerOrdinal> Ordinals,
SanitizerHandler Handler);
~SanitizerDebugLocation();
+ SanitizerDebugLocation(const SanitizerDebugLocation &) = delete;
+ SanitizerDebugLocation &operator=(SanitizerDebugLocation &) = delete;
};
} // namespace CodeGen
|
thurstond
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static analysis flagged these classes as having implemented the destructor but not applying rule of three. This could lead to accidental misuse and so it makes sense to apply it.