Skip to content

[asan] Pass -falign-functions=16 when building on Windows #154694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2025
Merged

[asan] Pass -falign-functions=16 when building on Windows #154694

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abaf75b
[asan] Pass -falign-functions=16 when building on Windows
zmodem Aug 21, 2025
0b10da1
use /hotpatch instead
zmodem Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions compiler-rt/lib/asan/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,14 @@ if(MSVC)
endif()
set(ASAN_CFLAGS ${SANITIZER_COMMON_CFLAGS})

# Win/ASan relies on the runtime having 16-byte aligned functions for
# hotpatching. See https://github.com/llvm/llvm-project/pull/149444
if(CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
if(CMAKE_CXX_SIMULATE_ID MATCHES "MSVC")
list(APPEND ASAN_CFLAGS /clang:-falign-functions=16)
endif()
endif()

append_list_if(MSVC /Zl ASAN_CFLAGS)

set(ASAN_COMMON_DEFINITIONS "")
Expand Down
Loading