Skip to content

Conversation

@topperc
Copy link
Collaborator

@topperc topperc commented Aug 21, 2025

I suspect this originally existed to avoid a trailing comma from the previous entry. C++ allows trailing commas in arrays so this isn't necessary.

I suspect this originally existed to avoid a trailing comma from
the previous entry. C++ allows trailing commas in arrays so this
isn't necessary.
@llvmbot
Copy link
Member

llvmbot commented Aug 21, 2025

@llvm/pr-subscribers-tablegen

Author: Craig Topper (topperc)

Changes

I suspect this originally existed to avoid a trailing comma from the previous entry. C++ allows trailing commas in arrays so this isn't necessary.


Full diff: https://github.com/llvm/llvm-project/pull/154778.diff

1 Files Affected:

  • (modified) llvm/utils/TableGen/CodeEmitterGen.cpp (+1-1)
diff --git a/llvm/utils/TableGen/CodeEmitterGen.cpp b/llvm/utils/TableGen/CodeEmitterGen.cpp
index d7b5e21c3f1fb..be468b012a8b7 100644
--- a/llvm/utils/TableGen/CodeEmitterGen.cpp
+++ b/llvm/utils/TableGen/CodeEmitterGen.cpp
@@ -440,7 +440,7 @@ void CodeEmitterGen::emitInstructionBaseValues(
     emitInstBits(O, Value);
     O << "," << '\t' << "// " << R->getName() << "\n";
   }
-  O << "    UINT64_C(0)\n  };\n";
+  O << "  };\n";
 }
 
 void CodeEmitterGen::emitCaseMap(

@topperc topperc merged commit c91f7dc into llvm:main Aug 21, 2025
11 checks passed
@topperc topperc deleted the pr/encoder-dummy branch August 21, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants