Skip to content

[TableGen] Remove unnecessary use of utostr when writing to raw_ostream. NFC #154800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 22, 2025
Merged

[TableGen] Remove unnecessary use of utostr when writing to raw_ostream. NFC #154800

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1939bd3
[TableGen] Remove unnecessary use of utostr when writing to raw_ostre…
topperc Aug 21, 2025
17cedbc
Merge remote-tracking branch 'origin/main' into pr/utostr
topperc Aug 21, 2025
84a17c8
fixup! address review comment
topperc Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions llvm/utils/TableGen/CodeEmitterGen.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,9 +154,9 @@ bool CodeEmitterGen::addCodeToMergeInOperand(const Record *R,
raw_string_ostream CaseOS(Case);
CaseOS << indent(6);
if (UseAPInt) {
CaseOS << EncoderMethodName << "(MI, " + utostr(OpIdx) << ", op";
CaseOS << EncoderMethodName << "(MI, " << OpIdx << ", op";
} else {
CaseOS << "op = " << EncoderMethodName << "(MI, " << utostr(OpIdx);
CaseOS << "op = " << EncoderMethodName << "(MI, " << OpIdx;
}
CaseOS << ", Fixups, STI);\n";
} else {
Expand Down Expand Up @@ -388,8 +388,7 @@ void CodeEmitterGen::addInstructionCasesForEncoding(

static void emitInstBits(raw_ostream &OS, const APInt &Bits) {
for (unsigned I = 0; I < Bits.getNumWords(); ++I)
OS << ((I > 0) ? ", " : "") << "UINT64_C(" << utostr(Bits.getRawData()[I])
<< ")";
OS << ((I > 0) ? ", " : "") << "UINT64_C(" << Bits.getRawData()[I] << ")";
}

void CodeEmitterGen::emitInstructionBaseValues(
Expand Down
Loading