Skip to content

[MLIR] Adopt LDBG() macro debugging in SymbolDCE.cpp (NFC) #155090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joker-eph merged 1 commit into from
Aug 23, 2025
Merged

[MLIR] Adopt LDBG() macro debugging in SymbolDCE.cpp (NFC) #155090

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 16 additions & 14 deletions mlir/lib/Transforms/SymbolDCE.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,11 @@

#include "mlir/Transforms/Passes.h"

#include "mlir/IR/Operation.h"
#include "mlir/IR/SymbolTable.h"
#include "llvm/Support/Debug.h"
#include "llvm/Support/DebugLog.h"
#include "llvm/Support/InterleavedRange.h"

namespace mlir {
#define GEN_PASS_DEF_SYMBOLDCE
Expand Down Expand Up @@ -87,8 +90,8 @@ LogicalResult SymbolDCE::computeLiveness(Operation *symbolTableOp,
SymbolTableCollection &symbolTable,
bool symbolTableIsHidden,
DenseSet<Operation *> &liveSymbols) {
LLVM_DEBUG(llvm::dbgs() << "computeLiveness: " << symbolTableOp->getName()
<< "\n");
LDBG() << "computeLiveness: "
<< OpWithFlags(symbolTableOp, OpPrintingFlags().skipRegions());
// A worklist of live operations to propagate uses from.
SmallVector<Operation *, 16> worklist;

Expand Down Expand Up @@ -116,21 +119,23 @@ LogicalResult SymbolDCE::computeLiveness(Operation *symbolTableOp,
// consideration.
while (!worklist.empty()) {
Operation *op = worklist.pop_back_val();
LLVM_DEBUG(llvm::dbgs() << "processing: " << op->getName() << "\n");
LDBG() << "processing: "
<< OpWithFlags(op, OpPrintingFlags().skipRegions());

// If this is a symbol table, recursively compute its liveness.
if (op->hasTrait<OpTrait::SymbolTable>()) {
// The internal symbol table is hidden if the parent is, if its not a
// symbol, or if it is a private symbol.
SymbolOpInterface symbol = dyn_cast<SymbolOpInterface>(op);
bool symIsHidden = symbolTableIsHidden || !symbol || symbol.isPrivate();
LLVM_DEBUG(llvm::dbgs() << "\tsymbol table: " << op->getName()
<< " is hidden: " << symIsHidden << "\n");
LDBG() << "\tsymbol table: "
<< OpWithFlags(op, OpPrintingFlags().skipRegions())
<< " is hidden: " << symIsHidden;
if (failed(computeLiveness(op, symbolTable, symIsHidden, liveSymbols)))
return failure();
} else {
LLVM_DEBUG(llvm::dbgs()
<< "\tnon-symbol table: " << op->getName() << "\n");
LDBG() << "\tnon-symbol table: "
<< OpWithFlags(op, OpPrintingFlags().skipRegions());
// If the op is not a symbol table, then, unless op itself is dead which
// would be handled by DCE, we need to check all the regions and blocks
// within the op to find the uses (e.g., consider visibility within op as
Expand Down Expand Up @@ -160,20 +165,17 @@ LogicalResult SymbolDCE::computeLiveness(Operation *symbolTableOp,
}

SmallVector<Operation *, 4> resolvedSymbols;
LLVM_DEBUG(llvm::dbgs() << "uses of " << op->getName() << "\n");
LDBG() << "uses of " << OpWithFlags(op, OpPrintingFlags().skipRegions());
for (const SymbolTable::SymbolUse &use : *uses) {
LLVM_DEBUG(llvm::dbgs() << "\tuse: " << use.getUser() << "\n");
LDBG() << "\tuse: " << use.getUser();
// Lookup the symbols referenced by this use.
resolvedSymbols.clear();
if (failed(symbolTable.lookupSymbolIn(parentOp, use.getSymbolRef(),
resolvedSymbols)))
// Ignore references to unknown symbols.
continue;
LLVM_DEBUG({
llvm::dbgs() << "\t\tresolved symbols: ";
llvm::interleaveComma(resolvedSymbols, llvm::dbgs());
llvm::dbgs() << "\n";
});
LDBG() << "\t\tresolved symbols: "
<< llvm::interleaved(resolvedSymbols, ", ");

// Mark each of the resolved symbols as live.
for (Operation *resolvedSymbol : resolvedSymbols)
Expand Down