Skip to content

[libc++][ranges] LWG4083: views::as_rvalue should reject non-input ranges #155156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 3, 2025
+14 −2
Merged

[libc++][ranges] LWG4083: views::as_rvalue should reject non-input ranges #155156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4bd066d
[libc++][ranges] LWG4083: `views::as_rvalue` should reject non-input …
H-G-Hristov Aug 24, 2025
95894ba
Merge branch 'main' into hgh/libcxx/LWG4083--views--as_rvalue-should-…
H-G-Hristov Aug 24, 2025
4cf7bc6
Addressed review comment
H-G-Hristov Sep 3, 2025
33dc1b4
Merge branch 'main' into hgh/libcxx/LWG4083--views--as_rvalue-should-…
H-G-Hristov Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libcxx/docs/Status/Cxx2cIssues.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
"`LWG4076 <https://wg21.link/LWG4076>`__","``concat_view`` should be freestanding","2024-06 (St. Louis)","","",""
"`LWG4079 <https://wg21.link/LWG4079>`__","Missing Preconditions in ``concat_view::iterator``\`s conversion constructor","2024-06 (St. Louis)","","",""
"`LWG4082 <https://wg21.link/LWG4082>`__","``views::concat(r)`` is well-formed when ``r`` is an ``output_range``","2024-06 (St. Louis)","","",""
"`LWG4083 <https://wg21.link/LWG4083>`__","``views::as_rvalue`` should reject non-input ranges","2024-06 (St. Louis)","","",""
"`LWG4083 <https://wg21.link/LWG4083>`__","``views::as_rvalue`` should reject non-input ranges","2024-06 (St. Louis)","|Complete|","22",""
"`LWG4096 <https://wg21.link/LWG4096>`__","``views::iota(views::iota(0))`` should be rejected","2024-06 (St. Louis)","|Complete|","22",""
"`LWG4098 <https://wg21.link/LWG4098>`__","``views::adjacent<0>`` should reject non-forward ranges","2024-06 (St. Louis)","","",""
"`LWG4105 <https://wg21.link/LWG4105>`__","``ranges::ends_with``\`s Returns misses difference casting","2024-06 (St. Louis)","","",""
Expand Down
2 changes: 1 addition & 1 deletion libcxx/include/__ranges/as_rvalue_view.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ struct __fn : __range_adaptor_closure<__fn> {
return /*---------------------------------*/ as_rvalue_view(std::forward<_Range>(__range));
}

template <class _Range>
template <input_range _Range>
requires same_as<range_rvalue_reference_t<_Range>, range_reference_t<_Range>>
[[nodiscard]] _LIBCPP_HIDE_FROM_ABI static constexpr auto
operator()(_Range&& __range) noexcept(noexcept(views::all(std::forward<_Range>(__range))))
Expand Down
12 changes: 12 additions & 0 deletions libcxx/test/std/ranges/range.adaptors/range.as.rvalue/adaptor.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,18 @@ struct move_iterator_range {
static_assert(!std::ranges::view<move_iterator_range>);
static_assert(std::ranges::range<move_iterator_range>);

// LWG4083: views::as_rvalue should reject non-input ranges
struct I {
int operator*();
using difference_type = int;
I& operator++();
void operator++(int);
};
static_assert(!std::is_invocable_v<decltype(std::views::as_rvalue),
decltype(std::ranges::subrange{I{}, std::unreachable_sentinel})>);
static_assert(
!HasPipe<decltype(std::ranges::subrange{I{}, std::unreachable_sentinel}), decltype(std::views::as_rvalue)>);

constexpr bool test() {
{ // view | views::as_rvalue
DefaultConstructibleView v{{}, 3};
Expand Down
Loading