[libc++][ranges] LWG3610: `iota_view::size` sometimes rejects integer-class types #155169

H-G-Hristov · 2025-08-24T14:11:59Z

Fixes #104948

Depends on #167869 for int128_t support.

References

…lass types Fixes llvm#104948 - https://wg21.link/LWG3610

llvmbot · 2025-08-24T14:12:28Z

@llvm/pr-subscribers-libcxx

Author: Hristo Hristov (H-G-Hristov)

Changes

Fixes #104948

https://wg21.link/LWG3610

Full diff: https://github.com/llvm/llvm-project/pull/155169.diff

3 Files Affected:

(modified) libcxx/docs/Status/Cxx23Issues.csv (+1-1)
(modified) libcxx/include/__ranges/iota_view.h (+1-1)
(modified) libcxx/test/std/ranges/range.factories/range.iota.view/size.pass.cpp (+18)

diff --git a/libcxx/docs/Status/Cxx23Issues.csv b/libcxx/docs/Status/Cxx23Issues.csv
index 189f8452e0678..38571dabae463 100644
--- a/libcxx/docs/Status/Cxx23Issues.csv
+++ b/libcxx/docs/Status/Cxx23Issues.csv
@@ -143,7 +143,7 @@
 "`LWG3598 <https://wg21.link/LWG3598>`__","``system_category().default_error_condition(0)`` is underspecified","2022-02 (Virtual)","","",""
 "`LWG3601 <https://wg21.link/LWG3601>`__","common_iterator's postfix-proxy needs ``indirectly_readable`` ","2022-02 (Virtual)","","",""
 "`LWG3607 <https://wg21.link/LWG3607>`__","``contiguous_iterator`` should not be allowed to have custom ``iter_move`` and ``iter_swap`` behavior","2022-02 (Virtual)","|Nothing To Do|","",""
-"`LWG3610 <https://wg21.link/LWG3610>`__","``iota_view::size`` sometimes rejects integer-class types","2022-02 (Virtual)","","",""
+"`LWG3610 <https://wg21.link/LWG3610>`__","``iota_view::size`` sometimes rejects integer-class types","2022-02 (Virtual)","|Complete|","22",""
 "`LWG3612 <https://wg21.link/LWG3612>`__","Inconsistent pointer alignment in ``std::format`` ","2022-02 (Virtual)","|Complete|","14",""
 "`LWG3616 <https://wg21.link/LWG3616>`__","LWG 3498 seems to miss the non-member ``swap`` for ``basic_syncbuf`` ","2022-02 (Virtual)","|Complete|","18",""
 "`LWG3618 <https://wg21.link/LWG3618>`__","Unnecessary ``iter_move`` for ``transform_view::iterator`` ","2022-02 (Virtual)","|Complete|","19",""
diff --git a/libcxx/include/__ranges/iota_view.h b/libcxx/include/__ranges/iota_view.h
index 4b84585258b91..cf401a4665fcd 100644
--- a/libcxx/include/__ranges/iota_view.h
+++ b/libcxx/include/__ranges/iota_view.h
@@ -348,7 +348,7 @@ class iota_view : public view_interface<iota_view<_Start, _BoundSentinel>> {
 
   _LIBCPP_HIDE_FROM_ABI constexpr auto size() const
     requires(same_as<_Start, _BoundSentinel> && __advanceable<_Start>) ||
-            (integral<_Start> && integral<_BoundSentinel>) || sized_sentinel_for<_BoundSentinel, _Start>
+            (__integer_like<_Start> && __integer_like<_BoundSentinel>) || sized_sentinel_for<_BoundSentinel, _Start>
   {
     if constexpr (__integer_like<_Start> && __integer_like<_BoundSentinel>) {
       return (__value_ < 0)
diff --git a/libcxx/test/std/ranges/range.factories/range.iota.view/size.pass.cpp b/libcxx/test/std/ranges/range.factories/range.iota.view/size.pass.cpp
index b894bc542be10..90afec2fba177 100644
--- a/libcxx/test/std/ranges/range.factories/range.iota.view/size.pass.cpp
+++ b/libcxx/test/std/ranges/range.factories/range.iota.view/size.pass.cpp
@@ -16,8 +16,21 @@
 #include <ranges>
 
 #include "test_macros.h"
+#define TEST_HAS_NO_INT128
+#include "type_algorithms.h"
 #include "types.h"
 
+template <typename T>
+concept HasSize = requires(const T t) { t.size(); };
+
+struct CheckForSize {
+  template <class T>
+  constexpr void operator()() {
+    static_assert(HasSize<std::ranges::iota_view<T, int>>);
+    static_assert(HasSize<std::ranges::iota_view<T, T>>);
+  }
+};
+
 constexpr bool test() {
   // Both are integer like and both are less than zero.
   {
@@ -99,6 +112,11 @@ constexpr bool test() {
     assert(sz == 10);
   }
 
+  // LWG3610: `iota_view::size` sometimes rejects integer-class types
+  {
+    types::for_each(types::integer_types{}, CheckForSize{});
+  }
+
   return true;
 }

frederick-vs-ja · 2025-08-24T15:57:13Z

I wondering that whether we treat __int128 as an extended integer type or an integer-class type. Also, I guess we should also cover _BitInt(N), see also #74161.

It seems to me that criteria for integer-class types are not very clear. CC @cjdb @ldionne.

H-G-Hristov · 2025-08-24T20:12:04Z

I wondering that whether we treat __int128 as an extended integer type or an integer-class type. Also, I guess we should also cover _BitInt(N), see also #74161.

It seems to me that criteria for integer-class types are not very clear. CC @cjdb @ldionne.

integer-like types bigger than long long aren't supported by iota_view:

llvm-project/libcxx/include/__ranges/iota_view.h

Line 64 in 44284cd

    
           sizeof(_Int) <= sizeof(long long), "Found integer-like type that is bigger than largest integer like type.");

frederick-vs-ja · 2025-08-24T23:51:17Z

I wondering that whether we treat __int128 as an extended integer type or an integer-class type. Also, I guess we should also cover _BitInt(N), see also #74161.
It seems to me that criteria for integer-class types are not very clear. CC @cjdb @ldionne.

integer-like types bigger than long long aren't supported by iota_view:

llvm-project/libcxx/include/__ranges/iota_view.h

Line 64 in 44284cd

sizeof(_Int) <= sizeof(long long), "Found integer-like type that is bigger than largest integer like type.");

Oh... Then we also need to test using integer-class type as the _BoundSentinel type while the _Start type is an integer type.

(And if we want to properly support extended integer types, the restriction should be relaxed.)

H-G-Hristov · 2025-08-25T08:22:31Z

I wondering that whether we treat __int128 as an extended integer type or an integer-class type. Also, I guess we should also cover _BitInt(N), see also #74161.
It seems to me that criteria for integer-class types are not very clear. CC @cjdb @ldionne.

integer-like types bigger than long long aren't supported by iota_view:

llvm-project/libcxx/include/__ranges/iota_view.h

Line 64 in 44284cd

sizeof(_Int) <= sizeof(long long), "Found integer-like type that is bigger than largest integer like type.");

Oh... Then we also need to test using integer-class type as the _BoundSentinel type while the _Start type is an integer type.

(And if we want to properly support extended integer types, the restriction should be relaxed.)

For the record: there was mentioning of supporting __int128_t in the original PR:
https://reviews.llvm.org/D107396?id=366123#inline-1028560
https://reviews.llvm.org/D107396?id=365533#inline-1026761
Would this patch be the appropriate place also to try to do the update to support _int128_t? These comments make me think it should be done.

…s-rejects-integer-class-types

H-G-Hristov · 2025-11-20T03:57:35Z

Verify here: https://ci.chromium.org/p/fuchsia/g/llvm/console

H-G-Hristov · 2025-11-20T03:59:33Z

@frederick-vs-ja #167869 should have resolved the int128_t issue.
I think this PR is good to go now. Waiting for the CI. Can you, please, have a look now?

ldionne

This generally looks fine, but I'd like @frederick-vs-ja to chime in.

ldionne · 2025-12-02T23:06:31Z

libcxx/test/std/ranges/range.factories/range.iota.view/iterator/subscript.pass.cpp


 constexpr bool test() {
  testType<SomeInt>();
+#ifndef TEST_HAS_NO_INT128


While we're at it, I suppose we could/should add int128_t support for the remaining member functions of iota_view?

Do you mean updating the remaining tests or something else? These specific changes are from my initial attempt to update iota_view to support int128_t, which was then implemented in #167869 and after I rebased I didn't remove them.

Yes, what I'm saying is that I think we can expand the testing for int128_t further. This should arguably have been done in #167869 but late is better than never.

[libc++][ranges] LWG3610: iota_view::size sometimes rejects integer-c…

44284cd

…lass types Fixes llvm#104948 - https://wg21.link/LWG3610

H-G-Hristov requested a review from a team as a code owner August 24, 2025 14:12

llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Aug 24, 2025

H-G-Hristov and others added 4 commits August 25, 2025 11:28

Updated test

bee2ac2

Added __int128_t support

1575d95

Merge branch 'main' into hgh/libcxx/LWG3610--iota_view--size-sometime…

d27f99b

…s-rejects-integer-class-types

Merge branch 'main' into hgh/libcxx/LWG3610--iota_view--size-sometime…

d5915c8

…s-rejects-integer-class-types

Zingam added the ranges Issues related to `<ranges>` label Sep 3, 2025

Zingam and others added 9 commits September 3, 2025 09:40

Merge branch 'main' into hgh/libcxx/LWG3610--iota_view--size-sometime…

81781fc

…s-rejects-integer-class-types

Merge branch 'main' into hgh/libcxx/LWG3610--iota_view--size-sometime…

881e98b

…s-rejects-integer-class-types

Merge branch 'main' into hgh/libcxx/LWG3610--iota_view--size-sometime…

c57e956

…s-rejects-integer-class-types

Merge branch 'main' into hgh/libcxx/LWG3610--iota_view--size-sometime…

3a65c32

…s-rejects-integer-class-types

Merge branch 'main' into hgh/libcxx/LWG3610--iota_view--size-sometime…

c81ae25

…s-rejects-integer-class-types

Revert changes

50bdaa9

Merge branch 'main' into hgh/libcxx/LWG3610--iota_view--size-sometime…

60e501e

…s-rejects-integer-class-types

Reverted too mucb

d8975ea

Cleanup

b410c1d

ldionne reviewed Dec 2, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[libc++][ranges] LWG3610: `iota_view::size` sometimes rejects integer-class types #155169

[libc++][ranges] LWG3610: `iota_view::size` sometimes rejects integer-class types #155169

H-G-Hristov commented Aug 24, 2025 •

edited

Loading

Uh oh!

llvmbot commented Aug 24, 2025

Uh oh!

frederick-vs-ja commented Aug 24, 2025

Uh oh!

H-G-Hristov commented Aug 24, 2025

Uh oh!

frederick-vs-ja commented Aug 24, 2025

Uh oh!

H-G-Hristov commented Aug 25, 2025 •

edited

Loading

Uh oh!

H-G-Hristov commented Nov 20, 2025

Uh oh!

H-G-Hristov commented Nov 20, 2025

Uh oh!

ldionne left a comment

Uh oh!

ldionne Dec 2, 2025

Uh oh!

H-G-Hristov Dec 4, 2025

Uh oh!

ldionne Dec 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[libc++][ranges] LWG3610: iota_view::size sometimes rejects integer-class types #155169

Are you sure you want to change the base?

[libc++][ranges] LWG3610: iota_view::size sometimes rejects integer-class types #155169

Conversation

H-G-Hristov commented Aug 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

References

Uh oh!

llvmbot commented Aug 24, 2025

Uh oh!

frederick-vs-ja commented Aug 24, 2025

Uh oh!

H-G-Hristov commented Aug 24, 2025

Uh oh!

frederick-vs-ja commented Aug 24, 2025

Uh oh!

H-G-Hristov commented Aug 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

H-G-Hristov commented Nov 20, 2025

Uh oh!

H-G-Hristov commented Nov 20, 2025

Uh oh!

ldionne left a comment

Choose a reason for hiding this comment

Uh oh!

ldionne Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

H-G-Hristov Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

ldionne Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[libc++][ranges] LWG3610: `iota_view::size` sometimes rejects integer-class types #155169

[libc++][ranges] LWG3610: `iota_view::size` sometimes rejects integer-class types #155169

H-G-Hristov commented Aug 24, 2025 •

edited

Loading

H-G-Hristov commented Aug 25, 2025 •

edited

Loading