Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions flang/lib/Optimizer/Transforms/SimplifyRegionLite.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -26,22 +26,16 @@ class SimplifyRegionLitePass
public:
void runOnOperation() override;
};

class DummyRewriter : public mlir::PatternRewriter {
public:
DummyRewriter(mlir::MLIRContext *ctx) : mlir::PatternRewriter(ctx) {}
};

} // namespace

void SimplifyRegionLitePass::runOnOperation() {
auto op = getOperation();
auto regions = op->getRegions();
mlir::RewritePatternSet patterns(op.getContext());
DummyRewriter rewriter(op.getContext());
if (regions.empty())
return;

mlir::PatternRewriter rewriter(op.getContext());
(void)mlir::eraseUnreachableBlocks(rewriter, regions);
(void)mlir::runRegionDCE(rewriter, regions);
}
Original file line number Diff line number Diff line change
Expand Up @@ -70,12 +70,7 @@ static FailureOr<LinalgOp> tryApply(Operation *operation, Args &&...args) {
PatternTy pattern(operation->getContext(), std::forward<Args>(args)...);
// We want to discourage direct use of PatternRewriter in APIs but In this
// very specific case, an IRRewriter is not enough.
struct TrivialPatternRewriter : public PatternRewriter {
public:
explicit TrivialPatternRewriter(MLIRContext *context)
: PatternRewriter(context) {}
};
TrivialPatternRewriter rewriter(operation->getContext());
PatternRewriter rewriter(operation->getContext());
rewriter.setInsertionPoint(operation);
auto result = pattern.returningMatchAndRewrite(op, rewriter);
if (failed(result))
Expand Down
7 changes: 1 addition & 6 deletions mlir/lib/Dialect/Transform/PDLExtension/PDLExtensionOps.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -100,12 +100,7 @@ LogicalResult PatternApplicatorExtension::findAllMatches(
PatternApplicator applicator(it->second);
// We want to discourage direct use of PatternRewriter in APIs but In this
// very specific case, an IRRewriter is not enough.
struct TrivialPatternRewriter : public PatternRewriter {
public:
explicit TrivialPatternRewriter(MLIRContext *context)
: PatternRewriter(context) {}
};
TrivialPatternRewriter rewriter(root->getContext());
PatternRewriter rewriter(root->getContext());
applicator.applyDefaultCostModel();
root->walk([&](Operation *op) {
if (succeeded(applicator.matchAndRewrite(op, rewriter)))
Expand Down
7 changes: 1 addition & 6 deletions mlir/unittests/Rewrite/PatternBenefit.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -66,12 +66,7 @@ TEST(PatternBenefitTest, BenefitOrder) {
PatternApplicator pa(frozenPatterns);
pa.applyDefaultCostModel();

class MyPatternRewriter : public PatternRewriter {
public:
MyPatternRewriter(MLIRContext *ctx) : PatternRewriter(ctx) {}
};

MyPatternRewriter rewriter(&context);
PatternRewriter rewriter(&context);
(void)pa.matchAndRewrite(*module, rewriter);

EXPECT_TRUE(called1);
Expand Down