-
Notifications
You must be signed in to change notification settings - Fork 15.2k
[AMDGPU] Remove setcc by using add/sub carryout #155255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
LU-JOHN
wants to merge
18
commits into
llvm:main
Choose a base branch
from
LU-JOHN:remove_setcc_stacked
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 17 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
7777081
Add test ensuring S_UADDO_PSEUDO selection
LU-JOHN 3cc1478
Streamline testcase
LU-JOHN 9a602ad
Update tests
LU-JOHN 14930a1
Set all bits for wave mask
LU-JOHN 731d6ce
Use same subtarget. Test sub.
LU-JOHN c82304e
Rename testcase
LU-JOHN b47c28f
Remove setcc by using add/sub carryout
LU-JOHN 19a0a2e
Get hi-half cleanly
LU-JOHN c182a9a
Use sd_match. Make comment clearer.
LU-JOHN a3b46db
Use getValue
LU-JOHN 54ab1cc
Use explicit type
LU-JOHN f98e651
Update new tests
LU-JOHN 1195022
Calc IsVALU correctly during UADDO/USUBO selection
LU-JOHN 7c30e38
Do not generate S_CMP if add/sub carryout is available
LU-JOHN d88ffc5
Limit search. Make code clearer.
LU-JOHN 054964c
Delete unnecessary S_CMP in separate PR
LU-JOHN 5be1306
Update tests
LU-JOHN a9ced61
Address feedback
LU-JOHN File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.