-
Notifications
You must be signed in to change notification settings - Fork 15.2k
Add AArch64 support to the premerge tests #155274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tstellar
wants to merge
76
commits into
llvm:main
Choose a base branch
from
tstellar:aarch64-ci
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+44
−15
Open
Changes from all commits
Commits
Show all changes
76 commits
Select commit
Hold shift + click to select a range
57697a6
Add AArch64 support to the premerge tests
tstellar 8ba375b
Fix typo
tstellar af39d1a
Fix quotes
tstellar 0330faf
Fix container name
tstellar 0492ee6
Fix format string
tstellar 493970e
Drop cpus
tstellar 7a41979
Debug
tstellar 25c28a1
change containre
tstellar 766987c
Use standard runners
tstellar 5f12fa2
Drop containe
tstellar 31393e3
Debug image
tstellar c7e1a03
Debug image
tstellar f7ae102
Debug image
tstellar f6a5df8
Debug containre
tstellar 452a347
Debug
tstellar 79e6def
Debug
tstellar a827aa7
Debug containr
tstellar ef27441
Debug containr
tstellar 0b85fe1
Fix typo
tstellar 6fe2008
Fix typo
tstellar 0a082cb
More debug
tstellar 2e1badd
Fix
tstellar 92a0d64
Switch to depot runners
tstellar 05823e9
Remove debugging
tstellar 0f11e40
Test for CI
tstellar 9fca728
Add in sccache
tstellar 8ff572d
Disable sccache setup
tstellar 7eab71c
Fix typo
tstellar fce2dc7
fix typo
tstellar 4724264
Debug
tstellar 5a68096
Fix regex
tstellar 12913f6
fix with containers
tstellar 62c28bf
Try to fix bash
tstellar 66b9eea
Fix sccache
tstellar bf0a79f
Fix sccache
tstellar 3360630
Disable sccache
tstellar 51216e7
Disable sccache
tstellar 8b5162a
Fix lldb tests and use a bigger machine
tstellar f5ebffd
Merge remote-tracking branch 'origin/main' into HEAD
tstellar 4282579
Add fast-fail
tstellar 079c4b1
Fix typo
tstellar 1c17b6f
Merge remote-tracking branch 'origin/main' into HEAD
tstellar c972560
Revert "Disable sccache"
tstellar ac5e6fe
Remove ccache hack
tstellar 0eb5481
Disable failing lldb test and use native sscache
tstellar 86813cb
Fix typo
tstellar 2a385ff
Enable sccache
tstellar 690300a
Fix names
tstellar 3a4b6af
Try again with filtering out tests
tstellar 60d13b4
Fix sccache
tstellar 3b62739
Fix runner arch
tstellar 9c6141b
Fix artifacts
tstellar a88a1f7
Try to fix sccache
tstellar a5bbb38
Merge remote-tracking branch 'origin/main' into HEAD
tstellar d472379
Skip TestVariableAnnotationsDisassembler.py on non-x86 architectures
UltimateForce21 d2fd1f4
sccache fix and debug
tstellar 8e3c676
Fix sccache
tstellar 3fa985b
Use bigger machine to avoid running out of disk
tstellar a405230
Fix platform title
tstellar fa8ad42
Merge remote-tracking branch 'origin/main' into HEAD
tstellar 1325760
Fix test display
tstellar 3312bf2
Fix test header
tstellar 169ee47
Fix python formatting
tstellar 1aed3e4
Remove readme change
tstellar 87994d0
More Fixes
tstellar a77d804
Merge remote-tracking branch 'origin/main' into HEAD
tstellar 029adf4
Prevent TestqOffsets.py picking up host binaries
DavidSpickett 24e0635
platform select instead
DavidSpickett e8ce7c4
Re-enable failing tests
tstellar f149c2b
Merge branch 'main' into aarch64-ci
tstellar 2a99adc
Continue-on-error
tstellar cad0933
Merge remote-tracking branch 'origin/main' into aarch64-ci
tstellar fa2cdff
Merge remote-tracking branch 'origin/main' into aarch64-ci
tstellar edfef13
Remove cache files
tstellar 4201876
Cache fix
tstellar bb08587
Merge branch 'main' into aarch64-ci
tstellar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,17 +24,40 @@ concurrency: | |
|
||
jobs: | ||
premerge-checks-linux: | ||
name: Build and Test Linux | ||
name: Build and Test Linux ${{ (startsWith(matrix.runs-on, 'depot-ubuntu-24.04-arm') && 'AArch64') || 'X86_64' }} | ||
if: >- | ||
github.repository_owner == 'llvm' && | ||
(github.event_name != 'pull_request' || github.event.action != 'closed') | ||
runs-on: llvm-premerge-linux-runners | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
runs-on: | ||
- depot-ubuntu-24.04-arm-16 | ||
- llvm-premerge-linux-runners | ||
runs-on: ${{ matrix.runs-on }} | ||
container: | ||
image: ${{ (startsWith(matrix.runs-on, 'depot-ubuntu-24.04-arm') && format('ghcr.io/{0}/arm64v8/ci-ubuntu-24.04',github.repository_owner) ) || null }} | ||
# --privileged is needed to run the lldb tests that disable aslr. | ||
# The SCCACHE environment variables are need to be copied from the host | ||
# to the container to make sure it is configured correctly to use the | ||
# depot cache. | ||
options: >- | ||
--privileged | ||
--env SCCACHE_WEBDAV_ENDPOINT | ||
--env SCCACHE_WEBDAV_TOKEN | ||
defaults: | ||
run: | ||
# The run step defaults to using sh as the shell when running in a | ||
# container, so make bash the default to ensure consistency between | ||
# container and non-container jobs. | ||
shell: bash | ||
steps: | ||
- name: Checkout LLVM | ||
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 | ||
with: | ||
fetch-depth: 2 | ||
- name: Build and Test | ||
continue-on-error: ${{ runner.arch == 'ARM64' }} | ||
run: | | ||
git config --global --add safe.directory '*' | ||
|
||
|
@@ -54,11 +77,14 @@ jobs: | |
export CC=/opt/llvm/bin/clang | ||
export CXX=/opt/llvm/bin/clang++ | ||
|
||
# This environment variable is passes into the container through the | ||
# runner pod definition. This differs between our two clusters which | ||
# why we do not hardcode it. | ||
export SCCACHE_GCS_BUCKET=$CACHE_GCS_BUCKET | ||
export SCCACHE_GCS_RW_MODE=READ_WRITE | ||
if [[ "${{ matrix.runs-on }}" = "llvm-premerge-linux-runners" ]]; then | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Make a note that this is conditional due to the different caching setup between GCP and AWS/depot? |
||
# This environment variable is passes into the container through the | ||
# runner pod definition. This differs between our two clusters which | ||
# why we do not hardcode it. | ||
export SCCACHE_GCS_BUCKET=$CACHE_GCS_BUCKET | ||
export SCCACHE_GCS_RW_MODE=READ_WRITE | ||
fi | ||
env | ||
|
||
# Set the idle timeout to zero to ensure sccache runs for the | ||
# entire duration of the job. Otherwise it might stop if we run | ||
|
@@ -78,7 +104,7 @@ jobs: | |
if: '!cancelled()' | ||
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2 | ||
with: | ||
name: Premerge Artifacts (Linux) | ||
name: Premerge Artifacts (Linux ${{ runner.arch }}) | ||
path: artifacts/ | ||
retention-days: 5 | ||
include-hidden-files: 'true' | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: It might be slightly cleaner to refactor this into a
compute_platform_title
function.