Skip to content

Conversation

philnik777
Copy link
Contributor

We've split the implementation-specific tests into libcxx/test/libcxx-03, so we don't need the annotations in libcxx/test/libcxx anymore.

@philnik777 philnik777 marked this pull request as ready for review August 26, 2025 14:25
@philnik777 philnik777 requested a review from a team as a code owner August 26, 2025 14:25
@philnik777 philnik777 merged commit 737cb78 into llvm:main Aug 26, 2025
66 of 70 checks passed
@philnik777 philnik777 deleted the cxx03_remove_libcxx_specific_xfails branch August 26, 2025 14:25
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Aug 26, 2025
@llvmbot
Copy link
Member

llvmbot commented Aug 26, 2025

@llvm/pr-subscribers-libcxx

Author: Nikolas Klauser (philnik777)

Changes

We've split the implementation-specific tests into libcxx/test/libcxx-03, so we don't need the annotations in libcxx/test/libcxx anymore.


Full diff: https://github.com/llvm/llvm-project/pull/155384.diff

2 Files Affected:

  • (modified) libcxx/test/libcxx/containers/sequences/deque/segmented_iterator.compile.pass.cpp (-2)
  • (modified) libcxx/test/libcxx/localization/locale.categories/__scan_keyword.pass.cpp (-2)
diff --git a/libcxx/test/libcxx/containers/sequences/deque/segmented_iterator.compile.pass.cpp b/libcxx/test/libcxx/containers/sequences/deque/segmented_iterator.compile.pass.cpp
index b050da4e36e85..1d5838abade7f 100644
--- a/libcxx/test/libcxx/containers/sequences/deque/segmented_iterator.compile.pass.cpp
+++ b/libcxx/test/libcxx/containers/sequences/deque/segmented_iterator.compile.pass.cpp
@@ -6,8 +6,6 @@
 //
 //===----------------------------------------------------------------------===//
 
-// XFAIL: FROZEN-CXX03-HEADERS-FIXME
-
 #include <deque>
 
 using DequeIterator = typename std::deque<int>::iterator;
diff --git a/libcxx/test/libcxx/localization/locale.categories/__scan_keyword.pass.cpp b/libcxx/test/libcxx/localization/locale.categories/__scan_keyword.pass.cpp
index 5f618e92375ae..ab05ba1da8114 100644
--- a/libcxx/test/libcxx/localization/locale.categories/__scan_keyword.pass.cpp
+++ b/libcxx/test/libcxx/localization/locale.categories/__scan_keyword.pass.cpp
@@ -35,8 +35,6 @@
 //                const _Ctype& __ct, ios_base::iostate& __err,
 //                bool __case_sensitive = true);
 
-// XFAIL: FROZEN-CXX03-HEADERS-FIXME
-
 #include <__locale_dir/scan_keyword.h>
 #include <cassert>
 #include <locale>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants