[clang-scan-deps] Remove unused OutputsPaths from FullDependencyConsumer (NFC) #155523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OutputPaths field of FullDependencyConsumer is not used, and the resulting TranslationUnitDeps has no corresponding field. This change removes the unused member. It was added in commit f978ea4, and this comment in the Differential Revision suggests it was intended to be removed before landing: https://reviews.llvm.org/D70268#1772032
|
@llvm/pr-subscribers-clang Author: Naveen Seth Hanig (naveen-seth) ChangesThe OutputPaths field of FullDependencyConsumer is not used, and the resulting TranslationUnitDeps has no corresponding field. This change removes the unused member. It was added in commit f978ea4, and this comment in the Differential Revision suggests it was intended to be removed before landing: https://reviews.llvm.org/D70268#1772032 Full diff: https://github.com/llvm/llvm-project/pull/155523.diff 1 Files Affected:
diff --git a/clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h b/clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h
index c3601a4e73e1f..f222ded8a966a 100644
--- a/clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h
+++ b/clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h
@@ -220,7 +220,6 @@ class FullDependencyConsumer : public DependencyConsumer {
std::vector<std::string> VisibleModules;
std::vector<Command> Commands;
std::string ContextHash;
- std::vector<std::string> OutputPaths;
const llvm::DenseSet<ModuleID> &AlreadySeen;
};
|
naveen-seth
changed the title
naveen-seth
force-pushed
the
full-deps-consumer-dead-code
branch
from
3ce4655 to
25dbd63
Compare
mahesh-attarde
pushed a commit
to mahesh-attarde/llvm-project
that referenced
this pull request
Oct 3, 2025
…mer (NFC) (llvm#155523) The OutputPaths field of FullDependencyConsumer is not used, and the resulting TranslationUnitDeps has no corresponding field. This change removes the unused member. It was added in commit f978ea4, and this comment in the Differential Revision suggests it was intended to be removed before landing: https://reviews.llvm.org/D70268#1772032
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OutputPaths field of FullDependencyConsumer is not used, and the resulting TranslationUnitDeps has no corresponding field. This change removes the unused member.
It was added in commit f978ea4, and this comment in the Differential Revision suggests it was intended to be removed before landing: https://reviews.llvm.org/D70268#1772032