-
Notifications
You must be signed in to change notification settings - Fork 15.4k
[clang][test] Add test for comma operator rejection in preprocessor conditionals #155570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
36f751e
[clang][test] Add tests for comma operator rejection in preprocessor …
swote-git 52bc5db
Add #elif test and CWG 3017 context
swote-git 1c32551
Add test for #if , (leading comma syntax error)
swote-git 728f872
Add test for #embed limit as a constant expression
swote-git aa99069
adding new line
swote-git 503b7c6
Address reviewer feedback for #embed test
swote-git File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| // RUN: %clang_cc1 -E -pedantic-errors %s -verify -std=c++98 | ||
| // RUN: %clang_cc1 -E -pedantic-errors %s -verify -std=c++11 | ||
| // RUN: %clang_cc1 -E -pedantic-errors %s -verify -std=c++14 | ||
| // RUN: %clang_cc1 -E -pedantic-errors %s -verify -std=c++17 | ||
| // RUN: %clang_cc1 -E -pedantic-errors %s -verify -std=c++20 | ||
| // RUN: %clang_cc1 -E -pedantic-errors %s -verify -std=c++23 | ||
|
|
||
| // Test 1: Top-level comma | ||
| // expected-error@+1 {{expected end of line in preprocessor expression}} | ||
Endilll marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| #if 1, 2 | ||
| #endif | ||
Endilll marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| // Test 2: Comma in conditional expression(CWG3017) | ||
| // Per CWG 3017, this exact case highlights the specification gap | ||
| // where C++ lacks explicit prohibition of comma operators in #if | ||
| // expected-error@+1 {{comma operator in operand of #if}} | ||
| #if 1 ? 1, 0 : 3 | ||
| #endif | ||
|
|
||
| // Test 3: Parenthesized comma | ||
| // expected-error@+1 {{comma operator in operand of #if}} | ||
| #if (1, 2) | ||
| #endif | ||
|
|
||
| // Test 4: Multiple commas | ||
| // expected-error@+1 {{expected end of line in preprocessor expression}} | ||
| #if 1, 2, 3 | ||
| #endif | ||
Endilll marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| // Test 5: Comma in #elif | ||
| #if 0 | ||
| #elif (1, 2) // expected-error {{comma operator in operand of #if}} | ||
| #endif | ||
|
|
||
Endilll marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| // Test 6: Leading comma (syntax error) | ||
| // expected-error@+1 {{invalid token at start of a preprocessor expression}} | ||
| #if , | ||
| #endif | ||
Endilll marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.