Skip to content

Conversation

@sarnex
Copy link
Member

@sarnex sarnex commented Aug 27, 2025

Need to require the target.

Fixes: #153318

@sarnex sarnex marked this pull request as ready for review August 27, 2025 19:01
@sarnex sarnex requested review from adam-yang and arsenm August 27, 2025 19:01
@llvmbot
Copy link
Member

llvmbot commented Aug 27, 2025

@llvm/pr-subscribers-debuginfo

Author: Nick Sarnie (sarnex)

Changes

Need to require the target.

Fixes: #153318


Full diff: https://github.com/llvm/llvm-project/pull/155678.diff

2 Files Affected:

  • (modified) llvm/test/tools/llvm-debuginfo-analyzer/DWARF/DW_AT_ranges.s (+2)
  • (modified) llvm/test/tools/llvm-debuginfo-analyzer/DWARF/high_pc_exclusive.s (+2)
diff --git a/llvm/test/tools/llvm-debuginfo-analyzer/DWARF/DW_AT_ranges.s b/llvm/test/tools/llvm-debuginfo-analyzer/DWARF/DW_AT_ranges.s
index 58d7b28b8d65e..daeda00f55644 100644
--- a/llvm/test/tools/llvm-debuginfo-analyzer/DWARF/DW_AT_ranges.s
+++ b/llvm/test/tools/llvm-debuginfo-analyzer/DWARF/DW_AT_ranges.s
@@ -16,6 +16,8 @@
 # 12   return (int)my_var;
 # 13 }
 
+# REQUIRES: x86-registered-target        
+
 # RUN: llvm-mc %s -triple=i686-pc-linux -filetype=obj -o - | \
 # RUN: llvm-debuginfo-analyzer --attribute=all \
 # RUN:                         --print=all \
diff --git a/llvm/test/tools/llvm-debuginfo-analyzer/DWARF/high_pc_exclusive.s b/llvm/test/tools/llvm-debuginfo-analyzer/DWARF/high_pc_exclusive.s
index efba25c46ae67..a9a90163667f6 100644
--- a/llvm/test/tools/llvm-debuginfo-analyzer/DWARF/high_pc_exclusive.s
+++ b/llvm/test/tools/llvm-debuginfo-analyzer/DWARF/high_pc_exclusive.s
@@ -12,6 +12,8 @@
 # 8 }
 # 9
 
+# REQUIRES: x86-registered-target
+
 # RUN: llvm-mc %s -triple=i686-pc-linux -filetype=obj -o - | \
 # RUN: llvm-debuginfo-analyzer --attribute=all \
 # RUN:                         --print=all \

Copy link
Contributor

@adam-yang adam-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!!

@sarnex sarnex merged commit 5bae366 into llvm:main Aug 27, 2025
13 checks passed
@sarnex
Copy link
Member Author

sarnex commented Aug 27, 2025

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants