-
Notifications
You must be signed in to change notification settings - Fork 15k
Add pointer auth documentation to contents #155763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@llvm/pr-subscribers-clang Author: Oliver Hunt (ojhunt) ChangesFull diff: https://github.com/llvm/llvm-project/pull/155763.diff 1 Files Affected:
diff --git a/clang/docs/index.rst b/clang/docs/index.rst
index 542bfc94cd576..be654af57f890 100644
--- a/clang/docs/index.rst
+++ b/clang/docs/index.rst
@@ -45,6 +45,7 @@ Using Clang as a Compiler
BoundsSafetyImplPlans
ControlFlowIntegrity
LTOVisibility
+ PointerAuthentication
SafeStack
ShadowCallStack
SourceBasedCodeCoverage
|
In a true miracle of editing prowess I did not actually add the pointer authentication docs to the content page \o/ Seriously not sure what section this should be in - This seems like a question for @AaronBallman or @kbeyls ? |
I think this looks good. I'm assuming that "user documentation" goes under the heading "Using Clang as a Compiler", which this PR does. I observe that there is also a section "Design Documents". I think that the pointer authentication documentation is much closer to "user documentation" than to "Design Documents", so I agree with the section you put it in, @ojhunt . It's easy to move it later to another section if another section would be better. |
Checked with Aaron and he feels this is ok :D |
/cherry-pick 6394c58 |
Error: Command failed due to missing milestone. |
/cherry-pick 6394c58 |
/pull-request #155954 |
(oh yay, you don't have to create a separate issue \o/ ) |
I cleverly hid the pointer authentication documentation by not adding it to the documentation contents. (cherry picked from commit 6394c58)
No description provided.