Skip to content

[flang] Don't associate pointers with zero sized storage targets #155867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 28, 2025
Merged

[flang] Don't associate pointers with zero sized storage targets #155867

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
96e80af
[flang] Don't associate pointers with zero sized storage targets
eugeneepshteyn Aug 28, 2025
2b671c3
Moved the check to PointerIsAssociatedWith()
eugeneepshteyn Aug 28, 2025
60addf8
Simplify
eugeneepshteyn Aug 28, 2025
eff8a33
Also check for array with no elements
eugeneepshteyn Aug 28, 2025
ca48aa4
clang-format
eugeneepshteyn Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions flang-rt/lib/runtime/pointer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,12 @@ void RTDEF(PointerAssociateScalar)(Descriptor &pointer, void *target) {
}

void RTDEF(PointerAssociate)(Descriptor &pointer, const Descriptor &target) {
pointer = target;
pointer.raw().attribute = CFI_attribute_pointer;
if (target.ElementBytes() > 0) {
Copy link
Contributor

@klausler klausler Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would leave the pointer unchanged when the target is an empty storage sequence, which would be wrong.

Copy link
Contributor

@DanielCChen DanielCChen Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. The pointer object will still need to get the dynamic type and etc from the target even though it's association status is not associated with the zero-sized storage sequence.

// F2023, 16.9.20, p5, case (v)-(vi): don't associate pointers with
// targets that have zero sized storage sequence.
pointer = target;
pointer.raw().attribute = CFI_attribute_pointer;
}
}

void RTDEF(PointerAssociateLowerBounds)(Descriptor &pointer,
Expand Down
Loading