Skip to content

[TableGen][DecoderEmitter] Rework table construction/emission #155889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Sep 20, 2025
Merged

[TableGen][DecoderEmitter] Rework table construction/emission #155889

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
e8fe951
tmp
s-barannikov Sep 16, 2025
7ccd80c
update tests
s-barannikov Sep 16, 2025
2d3301c
Address review comments
s-barannikov Sep 17, 2025
61a26b2
Rename DecoderTreeBuilder methods
s-barannikov Sep 17, 2025
8352f03
Clarify size computation of CheckAny node
s-barannikov Sep 17, 2025
cebaaf8
Avoid recursion when converting FilterChooser
s-barannikov Sep 17, 2025
9836fb5
Print the last child of CheckNode indented
s-barannikov Sep 17, 2025
bc4b239
Add a TODO with potential CheckAny optimization
s-barannikov Sep 17, 2025
547a6aa
Revert "Add a TODO with potential CheckAny optimization"
s-barannikov Sep 18, 2025
1722ed0
Extract DecoderTreeNode/DecoderTableEmitter into separate h/cpp files
s-barannikov Sep 18, 2025
8d903db
Change `auto` to `const_iterator` to suppress clang-tidy warnings
s-barannikov Sep 18, 2025
3036d96
Move/update comments, minor refactoring
s-barannikov Sep 18, 2025
9905b7e
Print CheckAny as a sequence of try-else, fix SoftFail output
s-barannikov Sep 18, 2025
1892e3f
Print single-bit bit range in more compact form
s-barannikov Sep 18, 2025
71a404e
Rename CommentIndex -> LineStartIndex, comment index-related members
s-barannikov Sep 18, 2025
bc91cb2
Add a TODO comment to emitCheckAllNode
s-barannikov Sep 18, 2025
2f68c1a
Explain why the last child of CheckAny/SwitchField is emitted differe…
s-barannikov Sep 18, 2025
38c5af0
Move predicate/decoder unification to tree construction stage
s-barannikov Sep 18, 2025
d7b6fcf
Really add a comment
s-barannikov Sep 18, 2025
3ed446e
Remove InstructionEncoding from DecodeNode
s-barannikov Sep 18, 2025
18fafdc
Document tree nodes
s-barannikov Sep 19, 2025
a574eb5
Merge branch 'main' into tablegen/decoder/tree
s-barannikov Sep 19, 2025
fdac726
Merge branch 'main' into tablegen/decoder/tree
s-barannikov Sep 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions llvm/include/llvm/MC/MCDecoderOps.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,18 +13,14 @@
namespace llvm::MCD {

// Disassembler state machine opcodes.
// nts_t is either uint16_t or uint24_t based on whether large decoder table is
// enabled.
enum DecoderOps {
OPC_Scope = 1, // OPC_Scope(nts_t NumToSkip)
OPC_ExtractField, // OPC_ExtractField(uleb128 Start, uint8_t Len)
OPC_FilterValueOrSkip, // OPC_FilterValueOrSkip(uleb128 Val, nts_t NumToSkip)
OPC_FilterValue, // OPC_FilterValue(uleb128 Val)
OPC_CheckField, // OPC_CheckField(uleb128 Start, uint8_t Len,
// uleb128 Val)
OPC_CheckPredicate, // OPC_CheckPredicate(uleb128 PIdx)
OPC_Decode, // OPC_Decode(uleb128 Opcode, uleb128 DIdx)
OPC_SoftFail, // OPC_SoftFail(uleb128 PMask, uleb128 NMask)
OPC_Scope = 1, // OPC_Scope(uleb128 Size)
OPC_SwitchField, // OPC_SwitchField(uleb128 Start, uint8_t Len,
// [uleb128 Val, uleb128 Size]...)
OPC_CheckField, // OPC_CheckField(uleb128 Start, uint8_t Len, uleb128 Val)
OPC_CheckPredicate, // OPC_CheckPredicate(uleb128 PIdx)
OPC_Decode, // OPC_Decode(uleb128 Opcode, uleb128 DIdx)
OPC_SoftFail, // OPC_SoftFail(uleb128 PMask, uleb128 NMask)
};

} // namespace llvm::MCD
Expand Down
44 changes: 22 additions & 22 deletions llvm/test/TableGen/DecoderEmitter/DecoderEmitterBitwidthSpecialization.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,14 +84,14 @@ def Inst3 : Instruction16Bit<3> {
// In the default case, we emit a single decodeToMCinst function and DecodeIdx
// is shared across all bitwidths.

// CHECK-DEFAULT-LABEL: DecoderTable8[25]
// CHECK-DEFAULT: DecodeIdx: 0
// CHECK-DEFAULT: DecodeIdx: 1
// CHECK-DEFAULT-LABEL: DecoderTable8
// CHECK-DEFAULT: using decoder 0
// CHECK-DEFAULT: using decoder 1
// CHECK-DEFAULT: };

// CHECK-DEFAULT-LABEL: DecoderTable16[25]
// CHECK-DEFAULT: DecodeIdx: 2
// CHECK-DEFAULT: DecodeIdx: 3
// CHECK-DEFAULT-LABEL: DecoderTable16
// CHECK-DEFAULT: using decoder 2
// CHECK-DEFAULT: using decoder 3
// CHECK-DEFAULT: };

// CHECK-DEFAULT-LABEL: template <typename InsnType>
Expand All @@ -105,10 +105,10 @@ def Inst3 : Instruction16Bit<3> {
// When we specialize per bitwidth, we emit 2 decodeToMCInst functions and
// DecodeIdx is assigned per bit width.

// CHECK-SPECIALIZE-NO-TABLE-LABEL: DecoderTable8[26]
// CHECK-SPECIALIZE-NO-TABLE: /* 0 */ 8, // Bitwidth 8
// CHECK-SPECIALIZE-NO-TABLE: DecodeIdx: 0
// CHECK-SPECIALIZE-NO-TABLE: DecodeIdx: 1
// CHECK-SPECIALIZE-NO-TABLE-LABEL: DecoderTable8
// CHECK-SPECIALIZE-NO-TABLE: 8, // 0: BitWidth 8
// CHECK-SPECIALIZE-NO-TABLE: using decoder 0
// CHECK-SPECIALIZE-NO-TABLE: using decoder 1
// CHECK-SPECIALIZE-NO-TABLE: };

// CHECK-SPECIALIZE-NO-TABLE-LABEL: template <typename InsnType>
Expand All @@ -117,10 +117,10 @@ def Inst3 : Instruction16Bit<3> {
// CHECK-SPECIALIZE-NO-TABLE: case 0
// CHECK-SPECIALIZE-NO-TABLE: case 1

// CHECK-SPECIALIZE-NO-TABLE-LABEL: DecoderTable16[26]
// CHECK-SPECIALIZE-NO-TABLE: /* 0 */ 16, // Bitwidth 16
// CHECK-SPECIALIZE-NO-TABLE: DecodeIdx: 0
// CHECK-SPECIALIZE-NO-TABLE: DecodeIdx: 1
// CHECK-SPECIALIZE-NO-TABLE-LABEL: DecoderTable16
// CHECK-SPECIALIZE-NO-TABLE: 16, // 0: BitWidth 16
// CHECK-SPECIALIZE-NO-TABLE: using decoder 0
// CHECK-SPECIALIZE-NO-TABLE: using decoder 1
// CHECK-SPECIALIZE-NO-TABLE: };

// CHECK-SPECIALIZE-NO-TABLE-LABEL: template <typename InsnType>
Expand All @@ -138,10 +138,10 @@ def Inst3 : Instruction16Bit<3> {
// Per bitwidth specialization with function table.

// 8 bit deccoder table, functions, and function table.
// CHECK-SPECIALIZE-TABLE-LABEL: DecoderTable8[26]
// CHECK-SPECIALIZE-TABLE: /* 0 */ 8, // Bitwidth 8
// CHECK-SPECIALIZE-TABLE: DecodeIdx: 0
// CHECK-SPECIALIZE-TABLE: DecodeIdx: 1
// CHECK-SPECIALIZE-TABLE-LABEL: DecoderTable8
// CHECK-SPECIALIZE-TABLE: 8, // 0: BitWidth 8
// CHECK-SPECIALIZE-TABLE: using decoder 0
// CHECK-SPECIALIZE-TABLE: using decoder 1
// CHECK-SPECIALIZE-TABLE: };

// CHECK-SPECIALIZE-TABLE-LABEL: template <typename InsnType>
Expand All @@ -161,10 +161,10 @@ def Inst3 : Instruction16Bit<3> {
// CHECK-SPECIALIZE-TABLE-NEXT: };

// 16 bit deccoder table, functions, and function table.
// CHECK-SPECIALIZE-TABLE-LABEL: DecoderTable16[26]
// CHECK-SPECIALIZE-TABLE: /* 0 */ 16, // Bitwidth 16
// CHECK-SPECIALIZE-TABLE: DecodeIdx: 0
// CHECK-SPECIALIZE-TABLE: DecodeIdx: 1
// CHECK-SPECIALIZE-TABLE-LABEL: DecoderTable16
// CHECK-SPECIALIZE-TABLE: 16, // 0: BitWidth 16
// CHECK-SPECIALIZE-TABLE: using decoder 0
// CHECK-SPECIALIZE-TABLE: using decoder 1
// CHECK-SPECIALIZE-TABLE: };

// CHECK-SPECIALIZE-TABLE-LABEL: template <typename InsnType>
Expand Down
28 changes: 12 additions & 16 deletions llvm/test/TableGen/DecoderEmitter/VarLenDecoder.td
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// RUN: llvm-tblgen -gen-disassembler -I %p/../../../include %s | FileCheck %s --check-prefixes=CHECK,CHECK-SMALL
// RUN: llvm-tblgen -gen-disassembler --large-decoder-table -I %p/../../../include %s | FileCheck %s --check-prefixes=CHECK,CHECK-LARGE
// RUN: llvm-tblgen -gen-disassembler -I %p/../../../include %s | FileCheck %s --check-prefixes=CHECK

include "llvm/Target/Target.td"

Expand Down Expand Up @@ -53,19 +52,16 @@ def FOO32 : MyVarInst<MemOp32> {
// CHECK-NEXT: 43,
// CHECK-NEXT: };

// CHECK-SMALL: /* 0 */ OPC_ExtractField, 3, 5, // Field = Inst{7-3}
// CHECK-SMALL-NEXT: /* 3 */ OPC_FilterValueOrSkip, 8, 4, 0, // if Field != 0x8 skip to 11
// CHECK-SMALL-NEXT: /* 7 */ OPC_Decode, {{[0-9]+}}, {{[0-9]+}}, 0, // Opcode: FOO16
// CHECK-SMALL-NEXT: /* 11 */ OPC_FilterValue, 9, // if Field != 0x9 pop scope
// CHECK-SMALL-NEXT: /* 13 */ OPC_Decode, {{[0-9]+}}, {{[0-9]+}}, 1, // Opcode: FOO32
// CHECK-SMALL-NEXT: };

// CHECK-LARGE: /* 0 */ OPC_ExtractField, 3, 5, // Field = Inst{7-3}
// CHECK-LARGE-NEXT: /* 3 */ OPC_FilterValueOrSkip, 8, 4, 0, 0, // if Field != 0x8 skip to 12
// CHECK-LARGE-NEXT: /* 8 */ OPC_Decode, {{[0-9]+}}, {{[0-9]+}}, 0, // Opcode: FOO16
// CHECK-LARGE-NEXT: /* 12 */ OPC_FilterValue, 9, // if Field != 0x9 pop scope
// CHECK-LARGE-NEXT: /* 14 */ OPC_Decode, {{[0-9]+}}, {{[0-9]+}}, 1, // Opcode: FOO32
// CHECK-LARGE-NEXT: };
// CHECK-LABEL: static const uint8_t DecoderTable43[15] = {
// CHECK-NEXT: OPC_SwitchField, 3, 5, // 0: switch Inst[7:3] {
// CHECK-NEXT: 8, 4, // 3: case 0x8: {
// CHECK-NEXT: OPC_Decode, {{[0-9, ]+}}, 0, // 5: decode to FOO16 using decoder 0
// CHECK-NEXT: // 5: }
// CHECK-NEXT: 9, 0, // 9: case 0x9: {
// CHECK-NEXT: OPC_Decode, {{[0-9, ]+}}, 1, // 11: decode to FOO32 using decoder 1
// CHECK-NEXT: // 11: }
// CHECK-NEXT: // 11: } // switch Inst[7:3]
// CHECK-NEXT: };

// CHECK: case 0:
// CHECK-NEXT: tmp = fieldFromInstruction(insn, 8, 3);
Expand All @@ -86,7 +82,7 @@ def FOO32 : MyVarInst<MemOp32> {
// CHECK-NEXT: MI.addOperand(MCOperand::createImm(tmp));
// CHECK-NEXT: return S;

// CHECK-LABEL: case OPC_ExtractField: {
// CHECK-LABEL: case OPC_SwitchField: {
// CHECK: makeUp(insn, Start + Len);

// CHECK-LABEL: case OPC_CheckField: {
Expand Down
58 changes: 36 additions & 22 deletions llvm/test/TableGen/DecoderEmitter/additional-encoding.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,28 +30,42 @@ class I<dag out_ops, dag in_ops> : Instruction {
let OutOperandList = out_ops;
}

// CHECK: /* 0 */ OPC_ExtractField, 12, 4, // Field = Inst{15-12}
// CHECK-NEXT: /* 3 */ OPC_FilterValueOrSkip, 0, 15, 0, // if Field != 0x0 skip to 22
// CHECK-NEXT: /* 7 */ OPC_Scope, 8, 0, // end scope at 18
// CHECK-NEXT: /* 10 */ OPC_CheckField, 6, 6, 0, // if Inst{11-6} != 0x0
// CHECK-NEXT: /* 14 */ OPC_Decode, {{[0-9]+}}, 2, 0, // Opcode: {{.*}}:NOP, DecodeIdx: 0
// CHECK-NEXT: /* 18 */ OPC_Decode, {{[0-9]+}}, 2, 1, // Opcode: SHIFT0, DecodeIdx: 1
// CHECK-NEXT: /* 22 */ OPC_FilterValueOrSkip, 1, 15, 0, // if Field != 0x1 skip to 41
// CHECK-NEXT: /* 26 */ OPC_Scope, 8, 0, // end scope at 37
// CHECK-NEXT: /* 29 */ OPC_CheckField, 6, 6, 0, // if Inst{11-6} != 0x0
// CHECK-NEXT: /* 33 */ OPC_Decode, {{[0-9]+}}, 2, 0, // Opcode: {{.*}}:NOP, DecodeIdx: 0
// CHECK-NEXT: /* 37 */ OPC_Decode, {{[0-9]+}}, 2, 1, // Opcode: SHIFT1, DecodeIdx: 1
// CHECK-NEXT: /* 41 */ OPC_FilterValueOrSkip, 2, 15, 0, // if Field != 0x2 skip to 60
// CHECK-NEXT: /* 45 */ OPC_Scope, 8, 0, // end scope at 56
// CHECK-NEXT: /* 48 */ OPC_CheckField, 6, 6, 0, // if Inst{11-6} != 0x0
// CHECK-NEXT: /* 52 */ OPC_Decode, {{[0-9]+}}, 2, 0, // Opcode: {{.*}}:NOP, DecodeIdx: 0
// CHECK-NEXT: /* 56 */ OPC_Decode, {{[0-9]+}}, 2, 1, // Opcode: SHIFT2, DecodeIdx: 1
// CHECK-NEXT: /* 60 */ OPC_FilterValue, 3, // if Field != 0x3
// CHECK-NEXT: /* 62 */ OPC_Scope, 8, 0, // end scope at 73
// CHECK-NEXT: /* 65 */ OPC_CheckField, 6, 6, 0, // if Inst{11-6} != 0x0
// CHECK-NEXT: /* 69 */ OPC_Decode, {{[0-9]+}}, 2, 0, // Opcode: {{.*}}:NOP, DecodeIdx: 0
// CHECK-NEXT: /* 73 */ OPC_Decode, {{[0-9]+}}, 2, 1, // Opcode: SHIFT3, DecodeIdx: 1

// CHECK-LABEL: static const uint8_t DecoderTable16[67] = {
// CHECK-NEXT: OPC_SwitchField, 12, 4, // 0: switch Inst[15:12] {
// CHECK-NEXT: 0, 14, // 3: case 0x0: {
// CHECK-NEXT: OPC_Scope, 8, // 5: try {
// CHECK-NEXT: OPC_CheckField, 6, 6, 0, // 7: check Inst[11:6] == 0x0
// CHECK-NEXT: OPC_Decode, {{[0-9, ]+}}, 0, // 11: decode to NOP using decoder 0
// CHECK-NEXT: // 11: } else try {
// CHECK-NEXT: OPC_Decode, {{[0-9, ]+}}, 1, // 15: decode to SHIFT0 using decoder 1
// CHECK-NEXT: // 15: }
// CHECK-NEXT: // 15: }
// CHECK-NEXT: 1, 14, // 19: case 0x1: {
// CHECK-NEXT: OPC_Scope, 8, // 21: try {
// CHECK-NEXT: OPC_CheckField, 6, 6, 0, // 23: check Inst[11:6] == 0x0
// CHECK-NEXT: OPC_Decode, {{[0-9, ]+}}, 0, // 27: decode to {{.*}}:NOP using decoder 0
// CHECK-NEXT: // 27: } else try {
// CHECK-NEXT: OPC_Decode, {{[0-9, ]+}}, 1, // 31: decode to SHIFT1 using decoder 1
// CHECK-NEXT: // 31: }
// CHECK-NEXT: // 31: }
// CHECK-NEXT: 2, 14, // 35: case 0x2: {
// CHECK-NEXT: OPC_Scope, 8, // 37: try {
// CHECK-NEXT: OPC_CheckField, 6, 6, 0, // 39: check Inst[11:6] == 0x0
// CHECK-NEXT: OPC_Decode, {{[0-9, ]+}}, 0, // 43: decode to {{.*}}:NOP using decoder 0
// CHECK-NEXT: // 43: } else try {
// CHECK-NEXT: OPC_Decode, {{[0-9, ]+}}, 1, // 47: decode to SHIFT2 using decoder 1
// CHECK-NEXT: // 47: }
// CHECK-NEXT: // 47: }
// CHECK-NEXT: 3, 0, // 51: case 0x3: {
// CHECK-NEXT: OPC_Scope, 8, // 53: try {
// CHECK-NEXT: OPC_CheckField, 6, 6, 0, // 55: check Inst[11:6] == 0x0
// CHECK-NEXT: OPC_Decode, {{[0-9, ]+}}, 0, // 59: decode to {{.*}}:NOP using decoder 0
// CHECK-NEXT: // 59: } else try {
// CHECK-NEXT: OPC_Decode, {{[0-9, ]+}}, 1, // 63: decode to SHIFT3 using decoder 1
// CHECK-NEXT: // 63: }
// CHECK-NEXT: // 63: }
// CHECK-NEXT: // 63: } // switch Inst[15:12]
// CHECK-NEXT: };

class SHIFT<bits<2> opc> : I<(outs), (ins ShAmtOp:$shamt)>, EncSHIFT<opc>;
def SHIFT0 : SHIFT<0>;
Expand Down
20 changes: 12 additions & 8 deletions llvm/test/TableGen/DecoderEmitter/big-filter.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,18 @@ class I : Instruction {

// Check that a 64-bit filter with all bits set does not confuse DecoderEmitter.
//
// CHECK-LABEL: static const uint8_t DecoderTable128[34] = {
// CHECK-NEXT: /* 0 */ OPC_ExtractField, 0, 64, // Field = Inst{63-0}
// CHECK-NEXT: /* 3 */ OPC_FilterValueOrSkip, 1, 8, 0, // if Field != 0x1 skip to 15
// CHECK-NEXT: /* 7 */ OPC_CheckField, 127, 1, 1, // if Inst{127} != 0x1
// CHECK-NEXT: /* 11 */ OPC_Decode, {{[0-9]+}}, 2, 0, // Opcode: I2, DecodeIdx: 0
// CHECK-NEXT: /* 15 */ OPC_FilterValue, 255, 255, 255, 255, 255, 255, 255, 255, 255, 1, // if Field != 0xffffffffffffffff
// CHECK-NEXT: /* 26 */ OPC_CheckField, 127, 1, 0, // if Inst{127} != 0x0
// CHECK-NEXT: /* 30 */ OPC_Decode, {{[0-9]+}}, 2, 0, // Opcode: I1, DecodeIdx: 0
// CHECK-LABEL: static const uint8_t DecoderTable128[32] = {
// CHECK-NEXT: OPC_SwitchField, 0, 64, // 0: switch Inst[63:0] {
// CHECK-NEXT: 1, 8, // 3: case 0x1: {
// CHECK-NEXT: OPC_CheckField, 127, 1, 1, // 5: check Inst[127] == 0x1
// CHECK-NEXT: OPC_Decode, {{[0-9, ]+}}, 0, // 9: decode to I2 using decoder 0
// CHECK-NEXT: // 9: }
// CHECK-NEXT: 255, 255, 255, 255, 255, 255, 255, 255, 255, 1, 0,
// CHECK-NEXT: // 13: case 0xffffffffffffffff: {
// CHECK-NEXT: OPC_CheckField, 127, 1, 0, // 24: check Inst[127] == 0x0
// CHECK-NEXT: OPC_Decode, {{[0-9, ]+}}, 0, // 28: decode to I1 using decoder 0
// CHECK-NEXT: // 28: }
// CHECK-NEXT: // 28: } // switch Inst[63:0]
// CHECK-NEXT: };

def I1 : I {
Expand Down
32 changes: 8 additions & 24 deletions llvm/test/TableGen/DecoderEmitter/trydecode-emission.td
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// RUN: llvm-tblgen -gen-disassembler -I %p/../../../include %s | FileCheck %s
// RUN: llvm-tblgen -gen-disassembler --large-decoder-table -I %p/../../../include %s | FileCheck %s --check-prefix=CHECK-LARGE

// Check that if decoding of an instruction fails and the instruction does not
// have a complete decoder method that can determine if the bitpattern is valid
Expand Down Expand Up @@ -34,29 +33,14 @@ def InstB : TestInstruction {
let hasCompleteDecoder = 0;
}

// CHECK: /* 0 */ OPC_CheckField, 4, 4, 0, // if Inst{7-4} != 0x0
// CHECK-NEXT: /* 4 */ OPC_Scope, 8, 0, // end scope at 15
// CHECK-NEXT: /* 7 */ OPC_CheckField, 2, 2, 0, // if Inst{3-2} != 0x0
// CHECK-NEXT: /* 11 */ OPC_Decode, {{[0-9]+}}, {{[0-9]+}}, 0, // Opcode: InstB, DecodeIdx: 0
// CHECK-NEXT: /* 15 */ OPC_Decode, {{[0-9]+}}, {{[0-9]+}}, 1, // Opcode: InstA, DecodeIdx: 1
// CHECK-LABEL: static const uint8_t DecoderTable8[18] = {
// CHECK-NEXT: OPC_CheckField, 4, 4, 0, // 0: check Inst[7:4] == 0x0
// CHECK-NEXT: OPC_Scope, 8, // 4: try {
// CHECK-NEXT: OPC_CheckField, 2, 2, 0, // 6: check Inst[3:2] == 0x0
// CHECK-NEXT: OPC_Decode, {{[0-9, ]+}}, 0, // 10: decode to InstB using decoder 0
// CHECK-NEXT: // 10: } else try {
// CHECK-NEXT: OPC_Decode, {{[0-9, ]+}}, 1, // 14: decode to InstA using decoder 1
// CHECK-NEXT: // 14: }
// CHECK-NEXT: };

// CHECK: if (!Check(S, DecodeInstB(MI, insn, Address, Decoder))) { DecodeComplete = false; return MCDisassembler::Fail; }

// CHECK: unsigned NumToSkip = *Ptr++;
// CHECK-NEXT: NumToSkip |= (*Ptr++) << 8;
// CHECK-NEXT: return NumToSkip;

// CHECK-LARGE: /* 0 */ OPC_CheckField, 4, 4, 0, // if Inst{7-4} != 0x0
// CHECK-LARGE-NEXT: /* 4 */ OPC_Scope, 8, 0, 0, // end scope at 16
// CHECK-LARGE-NEXT: /* 8 */ OPC_CheckField, 2, 2, 0, // if Inst{3-2} != 0x0
// CHECK-LARGE-NEXT: /* 12 */ OPC_Decode, {{[0-9]+}}, {{[0-9]+}}, 0, // Opcode: InstB, DecodeIdx: 0
// CHECK-LARGE-NEXT: /* 16 */ OPC_Decode, {{[0-9]+}}, {{[0-9]+}}, 1, // Opcode: InstA, DecodeIdx: 1
// CHECK-LARGE-NEXT: };

// CHECK-LARGE: if (!Check(S, DecodeInstB(MI, insn, Address, Decoder))) { DecodeComplete = false; return MCDisassembler::Fail; }

// CHECK-LARGE: unsigned NumToSkip = *Ptr++;
// CHECK-LARGE-NEXT: NumToSkip |= (*Ptr++) << 8;
// CHECK-LARGE-NEXT: NumToSkip |= (*Ptr++) << 16;
// CHECK-LARGE-NEXT: return NumToSkip;
31 changes: 11 additions & 20 deletions llvm/test/TableGen/DecoderEmitter/trydecode-emission2.td
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// RUN: llvm-tblgen -gen-disassembler -I %p/../../../include %s | FileCheck %s
// RUN: llvm-tblgen -gen-disassembler --large-decoder-table -I %p/../../../include %s | FileCheck %s --check-prefix=CHECK-LARGE

include "llvm/Target/Target.td"

Expand Down Expand Up @@ -31,25 +30,17 @@ def InstB : TestInstruction {
let hasCompleteDecoder = 0;
}

// CHECK: /* 0 */ OPC_CheckField, 2, 1, 0,
// CHECK-NEXT: /* 4 */ OPC_CheckField, 5, 3, 0,
// CHECK-NEXT: /* 8 */ OPC_Scope, 8, 0, // end scope at 19
// CHECK-NEXT: /* 11 */ OPC_CheckField, 0, 2, 3,
// CHECK-NEXT: /* 15 */ OPC_Decode, {{[0-9]+}}, {{[0-9]+}}, 0,
// CHECK-NEXT: /* 19 */ OPC_CheckField, 3, 2, 0,
// CHECK-NEXT: /* 23 */ OPC_Decode, {{[0-9]+}}, {{[0-9]+}}, 1,
// CHECK-LABEL: static const uint8_t DecoderTable8[26] = {
// CHECK-NEXT: OPC_CheckField, 2, 1, 0, // 0: check Inst[2] == 0x0
// CHECK-NEXT: OPC_CheckField, 5, 3, 0, // 4: check Inst[7:5] == 0x0
// CHECK-NEXT: OPC_Scope, 8, // 8: try {
// CHECK-NEXT: OPC_CheckField, 0, 2, 3, // 10: check Inst[1:0] == 0x3
// CHECK-NEXT: OPC_Decode, {{[0-9, ]+}}, 0, // 14: decode to InstB using decoder 0
// CHECK-NEXT: // 14: } else try {
// CHECK-NEXT: OPC_CheckField, 3, 2, 0, // 18: check Inst[4:3] == 0x0
// CHECK-NEXT: OPC_Decode, {{[0-9, ]+}}, 1, // 22: decode to InstA using decoder 1
// CHECK-NEXT: // 22: }
// CHECK-NEXT: };

// CHECK: if (!Check(S, DecodeInstB(MI, insn, Address, Decoder))) { DecodeComplete = false; return MCDisassembler::Fail; }
// CHECK: if (!Check(S, DecodeInstA(MI, insn, Address, Decoder))) { DecodeComplete = false; return MCDisassembler::Fail; }

// CHECK-LARGE: /* 0 */ OPC_CheckField, 2, 1, 0,
// CHECK-LARGE-NEXT: /* 4 */ OPC_CheckField, 5, 3, 0,
// CHECK-LARGE-NEXT: /* 8 */ OPC_Scope, 8, 0, 0, // end scope at 20
// CHECK-LARGE-NEXT: /* 12 */ OPC_CheckField, 0, 2, 3,
// CHECK-LARGE-NEXT: /* 16 */ OPC_Decode, {{[0-9]+}}, {{[0-9]+}}, 0,
// CHECK-LARGE-NEXT: /* 20 */ OPC_CheckField, 3, 2, 0,
// CHECK-LARGE-NEXT: /* 24 */ OPC_Decode, {{[0-9]+}}, {{[0-9]+}}, 1,
// CHECK-LARGE-NEXT: };

// CHECK-LARGE: if (!Check(S, DecodeInstB(MI, insn, Address, Decoder))) { DecodeComplete = false; return MCDisassembler::Fail; }
// CHECK-LARGE: if (!Check(S, DecodeInstA(MI, insn, Address, Decoder))) { DecodeComplete = false; return MCDisassembler::Fail; }
Loading