Skip to content

[mlir][spirv] Add pattern matching for arith.index_cast index to i1 for ArithToSPIRV #156031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 3, 2025
+54 −1
Merged

[mlir][spirv] Add pattern matching for arith.index_cast index to i1 for ArithToSPIRV #156031

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
6e1a6ab
Add conversion from arith.index_cast index->i1 to SPIRV
ianayl Aug 29, 2025
c03e924
clang-format
ianayl Aug 29, 2025
fa8db0a
remove redundant truncate
ianayl Aug 29, 2025
ca2e36a
clang-format
ianayl Aug 29, 2025
fa93f78
Fix comment
ianayl Aug 29, 2025
1ae814c
Amend comment
ianayl Aug 29, 2025
b5583a0
Apply reviewer comments
ianayl Sep 2, 2025
2815dbd
clang-format
ianayl Sep 2, 2025
cf86eb6
Fix compat with vector<?xi1>
ianayl Sep 2, 2025
68e6fb4
clang-format
ianayl Sep 2, 2025
eababdc
add support for single element vectors
ianayl Sep 3, 2025
ffc00d9
clang-format
ianayl Sep 3, 2025
5c2b72f
Change arg spacing in mlir tests
ianayl Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion mlir/lib/Conversion/ArithToSPIRV/ArithToSPIRV.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,6 +607,32 @@ struct UIToFPI1Pattern final : public OpConversionPattern<arith::UIToFPOp> {
}
};

//===----------------------------------------------------------------------===//
// IndexCastOp
//===----------------------------------------------------------------------===//

// Converts arith.index_cast to spirv.INotEqual if the target type is i1.
struct IndexCastIndexI1Pattern final
: public OpConversionPattern<arith::IndexCastOp> {
using OpConversionPattern::OpConversionPattern;

LogicalResult
matchAndRewrite(arith::IndexCastOp op, OpAdaptor adaptor,
ConversionPatternRewriter &rewriter) const override {
Type srcType = adaptor.getOperands().front().getType();
// Indexes have already been converted to its respective spirv type:
Type indexType = getTypeConverter<SPIRVTypeConverter>()->getIndexType();
if (srcType != indexType || !op.getType().isInteger(1))
return failure();

Location loc = op.getLoc();
Value zeroIdx = spirv::ConstantOp::getZero(srcType, loc, rewriter);
rewriter.replaceOpWithNewOp<spirv::INotEqualOp>(
op, rewriter.getI1Type(), zeroIdx, adaptor.getOperands().front());
return success();
}
};

//===----------------------------------------------------------------------===//
// ExtSIOp
//===----------------------------------------------------------------------===//
Expand Down Expand Up @@ -1328,7 +1354,7 @@ void mlir::arith::populateArithToSPIRVPatterns(
TypeCastingOpPattern<arith::SIToFPOp, spirv::ConvertSToFOp>,
TypeCastingOpPattern<arith::FPToUIOp, spirv::ConvertFToUOp>,
TypeCastingOpPattern<arith::FPToSIOp, spirv::ConvertFToSOp>,
TypeCastingOpPattern<arith::IndexCastOp, spirv::SConvertOp>,
TypeCastingOpPattern<arith::IndexCastOp, spirv::SConvertOp>, IndexCastIndexI1Pattern,
TypeCastingOpPattern<arith::IndexCastUIOp, spirv::UConvertOp>,
TypeCastingOpPattern<arith::BitcastOp, spirv::BitcastOp>,
CmpIOpBooleanPattern, CmpIOpPattern,
Expand Down
8 changes: 8 additions & 0 deletions mlir/test/Conversion/ArithToSPIRV/arith-to-spirv.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -734,6 +734,14 @@ func.func @index_castui4(%arg0: index) {
return
}

// CHECK-LABEL: index_castindexi1
func.func @index_castindexi1(%arg0 : index) {
// CHECK: %[[ZERO:.+]] = spirv.Constant 0 : i32
// CHECK: spirv.INotEqual %[[ZERO]], %{{.+}} : i32
%0 = arith.index_cast %arg0 : index to i1
return
}

// CHECK-LABEL: @bit_cast
func.func @bit_cast(%arg0: vector<2xf32>, %arg1: i64) {
// CHECK: spirv.Bitcast %{{.+}} : vector<2xf32> to vector<2xi32>
Expand Down