-
Notifications
You must be signed in to change notification settings - Fork 15.4k
[OpenACC] 'reduction' 'one-init' lowering, */&& operators. #156122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2589,6 +2589,59 @@ SemaOpenACC::ActOnOpenACCAsteriskSizeExpr(SourceLocation AsteriskLoc) { | |
| return BuildOpenACCAsteriskSizeExpr(AsteriskLoc); | ||
| } | ||
|
|
||
| /// Loops through a type and generates an appropriate InitListExpr to generate | ||
| /// type initialization. | ||
| static Expr *GenerateReductionInitRecipeExpr(ASTContext &Context, | ||
| SourceRange ExprRange, | ||
| QualType Ty) { | ||
| Ty = Ty.getCanonicalType(); | ||
| llvm::SmallVector<Expr *> Exprs; | ||
|
|
||
| if (const RecordDecl *RD = Ty->getAsRecordDecl()) { | ||
| for (auto *F : RD->fields()) { | ||
| if (Expr *NewExpr = | ||
| GenerateReductionInitRecipeExpr(Context, ExprRange, F->getType())) | ||
| Exprs.push_back(NewExpr); | ||
| else | ||
| return nullptr; | ||
| } | ||
| } else if (const ConstantArrayType *AT = Context.getAsConstantArrayType(Ty)) { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we ever get here with a non-constant array type? Is the type always constant because it's an initializer?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
At the moment, we CAN get here with a pointer/VLA, but I haven't figured out how to implement that yet, and will probably do so next (for a few things). I probably could use a NYI in the normal init generation for pointer types at the moment. BUT since that is not Reduction specific, I'll do that in a separate patch if thats OK.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There's code in
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah, well... its more than that. The length of the VLA component is going to come in from a different place, via a variable in the recipe, so we have to figure out how to get that, what to loop over, etc. It is more than just emitting the alloca, we have to do a full alloca of the right sizes then do the init. But that is a good thing to know about for when I have to figure that out. |
||
| for (uint64_t Idx = 0; Idx < AT->getZExtSize(); ++Idx) { | ||
| if (Expr *NewExpr = GenerateReductionInitRecipeExpr(Context, ExprRange, | ||
| AT->getElementType())) | ||
| Exprs.push_back(NewExpr); | ||
| else | ||
| return nullptr; | ||
| } | ||
|
|
||
| } else { | ||
| assert(Ty->isScalarType()); | ||
andykaylor marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| // TODO: OpenACC: This currently only works for '1', but we need to figure | ||
| // out a way to do least/largest/all-1s. | ||
| if (Ty->isFloatingType()) { | ||
| Exprs.push_back(FloatingLiteral::Create( | ||
| Context, llvm::APFloat::getOne(Context.getFloatTypeSemantics(Ty)), | ||
| /*isExact=*/true, Ty, ExprRange.getBegin())); | ||
| } else if (Ty->isPointerType()) { | ||
| // It isn't clear here what we can do, we don't know the intended | ||
| // size/etc, as that isn't present in the recipe. We probably have to come | ||
| // up with a way to have the bounds passed to these, but it isn't clear | ||
| // how that should work. | ||
| return nullptr; | ||
andykaylor marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| } else { | ||
| Exprs.push_back(IntegerLiteral::Create( | ||
andykaylor marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| Context, llvm::APInt(Context.getTypeSize(Ty), 1), Ty, | ||
| ExprRange.getBegin())); | ||
| } | ||
| } | ||
|
|
||
| Expr *InitExpr = new (Context) | ||
| InitListExpr(Context, ExprRange.getBegin(), Exprs, ExprRange.getEnd()); | ||
| InitExpr->setType(Ty); | ||
| return InitExpr; | ||
| } | ||
|
|
||
| std::pair<VarDecl *, VarDecl *> | ||
| SemaOpenACC::CreateInitRecipe(OpenACCClauseKind CK, | ||
| OpenACCReductionOperator ReductionOperator, | ||
|
|
@@ -2733,14 +2786,33 @@ SemaOpenACC::CreateInitRecipe(OpenACCClauseKind CK, | |
| // are used for code generation, we can just ignore/not bother doing any | ||
| // initialization here. | ||
| break; | ||
| case OpenACCReductionOperator::Multiplication: | ||
| case OpenACCReductionOperator::Max: | ||
| case OpenACCReductionOperator::Min: | ||
| case OpenACCReductionOperator::BitwiseAnd: | ||
| case OpenACCReductionOperator::And: | ||
| // TODO: OpenACC: figure out init for these. | ||
| break; | ||
|
|
||
| case OpenACCReductionOperator::Multiplication: | ||
| case OpenACCReductionOperator::And: { | ||
| // '&&' initializes every field to 1. However, we need to loop through | ||
| // every field/element and generate an initializer for each of the | ||
| // elements. | ||
|
|
||
| Expr *InitExpr = GenerateReductionInitRecipeExpr( | ||
| getASTContext(), VarExpr->getSourceRange(), VarTy); | ||
|
|
||
| if (InitExpr) { | ||
|
||
| InitializationKind Kind = InitializationKind::CreateForInit( | ||
| Recipe->getLocation(), /*DirectInit=*/true, InitExpr); | ||
| InitializationSequence InitSeq(SemaRef.SemaRef, Entity, Kind, | ||
| InitExpr, | ||
| /*TopLevelOfInitList=*/false, | ||
| /*TreatUnavailableAsInvalid=*/false); | ||
| Init = | ||
| InitSeq.Perform(SemaRef.SemaRef, Entity, Kind, InitExpr, &VarTy); | ||
| } | ||
| break; | ||
| } | ||
| case OpenACCReductionOperator::Addition: | ||
| case OpenACCReductionOperator::BitwiseOr: | ||
| case OpenACCReductionOperator::BitwiseXOr: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this could have an enum argument indicating the required initializer kind (zero, one, least, largest, all 1's, etc.).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I was thinking a few things, either that, or a function object/function pointer that knows how to do the lowering. I was intending to do that as a part of my patch though.