-
Notifications
You must be signed in to change notification settings - Fork 15.4k
LLVM Qualification Group - Backlog documentation and Discussion Updates #156184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…rom the main group page.
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
|
Hello @kbeyls , Thanks |
kbeyls
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can do a review, but can't review the details in depth as I'm not participating in the qualification working group.
I left a separate comment about the license header you're adding here: I'd remove that one.
Other than that, my main observation is that it might incur quite a bit of overhead to keep living documents in the llvm docs github repo.
Also, whenever an LLVM release is made, I guess that whatever state these documents are in at that point, will always be part of that LLVM release.
I think it might be better to keep living/frequently changing documents (like a backlog) in a document outside of the git repo. Other LLVM sync-up groups often use a public google doc or similar. Of course a pointer to the living document outside of the git repo could be very useful to have in the docs in git/on the website.
kbeyls
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me now.
Let me know if you can merge this (i.e. you see a merge button on the PR).
If not, I can merge this PR for you.
|
Hello @kbeyls , Thank you! |
|
@CarlosAndresRamirez Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR. Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues. How to do this, and the rest of the post-merge process, is covered in detail here. If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again. If you don't get any reports, no action is required from you. Your changes are working as expected, well done! |
Prevents a conflict with the modifications in llvm#156184 which adds a new section "Current Topics & Backlog", inexistent in this version.
I have created backlog file for the Qualification group that contains all the topics currently under discussion and I have added the new section in the main group's page, referencing the backlog.
This Backlog will be used as the quick reference for anyone to know what are the current topics under discussion and what priorities have been given to them by the group.
Note for future editors: Add "Last updated:" comment on top of the document, easily keep track of the last updated dates.