[libc++] Include __llvm-libc-common.h if applicable #156331
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
the
libc++
|
@llvm/pr-subscribers-libcxx Author: William Huynh (saturn691) ChangesCurrently on embedded platforms, Full diff: https://github.com/llvm/llvm-project/pull/156331.diff 1 Files Affected:
diff --git a/libcxx/include/__configuration/platform.h b/libcxx/include/__configuration/platform.h
index f3c199dee172b..cf7d9d965cf30 100644
--- a/libcxx/include/__configuration/platform.h
+++ b/libcxx/include/__configuration/platform.h
@@ -49,6 +49,11 @@
# include <picolibc.h>
#endif
+// TODO: we should remove this once (#147956) is merged, for the same reason as listed above.
+#if __has_include(<__llvm-libc-common.h>)
+# include <__llvm-libc-common.h>
+#endif
+
#ifndef __BYTE_ORDER__
# error \
"Your compiler doesn't seem to define __BYTE_ORDER__, which is required by libc++ to know the endianness of your target platform"
|
saturn691
added a commit
to saturn691/arm-toolchain
that referenced
this pull request
Sep 1, 2025
This is required for std::cout. This patch relies on the following: llvm/llvm-project#156330 llvm/llvm-project#156331
saturn691
added a commit
to saturn691/arm-toolchain
that referenced
this pull request
Sep 1, 2025
This is required for std::cout. This patch relies on the following: llvm/llvm-project#156330 llvm/llvm-project#156331
saturn691
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently on embedded platforms,
<features.h>is not being included. We need at least one of the LLVM-libc headers to be included, to have access to the define__LLVM_LIBC__. Therefore, as a temporary solution until #147956 is merged, we include a check for the LLVM-libc common header library.Corresponding PR in LLVM-libc is here: #156330.