Skip to content

[lld] Remove shell requirements from tests #156510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 3, 2025
Merged

[lld] Remove shell requirements from tests #156510

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0035741
[𝘀𝗽𝗿] initial version
boomanaiden154 Sep 2, 2025
8ca85bc
fix
boomanaiden154 Sep 2, 2025
c6ceee5
fix
boomanaiden154 Sep 2, 2025
c1fa39d
feedback
boomanaiden154 Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lld/test/COFF/color-diagnostics.test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Windows command prompt doesn't support ANSI escape sequences.
# REQUIRES: shell
# UNSUPPORTED: system-windows

# RUN: not lld-link -xyz --color-diagnostics /nosuchfile 2>&1 \
# RUN: | FileCheck -check-prefix=COLOR %s
Expand Down
4 changes: 3 additions & 1 deletion lld/test/COFF/linkrepro-res.test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
# REQUIRES: x86, shell
# REQUIRES: x86
# Unsupported on Windows due to maximum path length limitations.
# UNSUPPORTED: system-windows

# RUN: rm -rf %t.dir
# RUN: mkdir -p %t.dir/build
Expand Down
4 changes: 3 additions & 1 deletion lld/test/COFF/linkrepro.test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
# REQUIRES: x86, shell
# REQUIRES: x86
# Unsupported on Windows due to maximum path length limitations.
# UNSUPPORTED: system-windows

# RUN: rm -rf %t.dir
# RUN: split-file %s %t.dir
Expand Down
4 changes: 3 additions & 1 deletion lld/test/ELF/arm-exidx-range.s
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
// REQUIRES: arm, shell
// REQUIRES: arm
// Fails for unclear reasons on 32-bit windows
// UNSUPPORTED: system-windows
// RUN: llvm-mc --arm-add-build-attributes --triple=armv7a-linux-gnueabihf -filetype=obj %s -o %t.o
// RUN: echo "SECTIONS { \
// RUN: . = 0x80000000; \
Expand Down
2 changes: 1 addition & 1 deletion lld/test/ELF/color-diagnostics.test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Windows command prompt doesn't support ANSI escape sequences.
# REQUIRES: shell
# UNSUPPORTED: system-windows

# RUN: not ld.lld -xyz --color-diagnostics /nosuchfile 2>&1 \
# RUN: | FileCheck -check-prefix=COLOR %s
Expand Down
3 changes: 2 additions & 1 deletion lld/test/ELF/file-access.s
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# REQUIRES: x86, shell
# REQUIRES: x86
# UNSUPPORTED: system-windows

# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o
# RUN: ld.lld -r %t.o -o %t1.o
Expand Down
2 changes: 1 addition & 1 deletion lld/test/ELF/linkerscript/invalid.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
## We can't write quoted strings that are interpreted the same way
## by all echo commands. So, we don't want to run this on Windows.

# REQUIRES: shell
# UNSUPPORTED: system-windows

# RUN: mkdir -p %t.dir

Expand Down
2 changes: 1 addition & 1 deletion lld/test/ELF/lto/resolution-err.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
; UNSUPPORTED: system-windows
; REQUIRES: shell, non-root-user
; REQUIRES: non-root-user
; RUN: llvm-as %s -o %t.bc
; RUN: touch %t.resolution.txt
; RUN: chmod u-w %t.resolution.txt
Expand Down
2 changes: 1 addition & 1 deletion lld/test/MachO/color-diagnostics.test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Windows command prompt doesn't support ANSI escape sequences.
# REQUIRES: shell
# UNSUPPORTED: system-windows

# RUN: not %lld --color-diagnostics /nosuchfile 2>&1 \
# RUN: | FileCheck -check-prefix=COLOR %s
Expand Down
3 changes: 2 additions & 1 deletion lld/test/MachO/framework.s
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# REQUIRES: x86, shell
# REQUIRES: x86
# UNSUPPORTED: system-windows
# RUN: rm -rf %t; split-file %s %t
# RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %t/foo.s -o %t/foo.o
# RUN: mkdir -p %t/Foo.framework/Versions/A
Expand Down
5 changes: 4 additions & 1 deletion lld/test/MachO/implicit-and-allowable-clients.test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
# REQUIRES: aarch64, shell
# ln -s is not guaranteed to work on Windows
# UNSUPPORTED: system-windows

# REQUIRES: aarch64
# RUN: rm -rf %t; split-file %s %t
# RUN: ln -s Versions/A/FrameworkPublic.tbd %t/System/Library/Frameworks/FrameworkPublic.framework/
# RUN: ln -s Versions/A/FrameworkPrivate.tbd %t/System/Library/Frameworks/FrameworkPrivate.framework/
Expand Down
4 changes: 3 additions & 1 deletion lld/test/MachO/link-search-at-loader-path-symlink.s
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
# REQUIRES: x86, shell
# REQUIRES: x86
# Windows does not support rpath
# UNSUPPORTED: system-windows

# RUN: rm -rf %t; split-file %s %t

Expand Down
3 changes: 2 additions & 1 deletion lld/test/MachO/reexport-with-symlink.s
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# REQUIRES: aarch64, shell
# REQUIRES: aarch64
# UNSUPPORTED: system-windows
# RUN: rm -rf %t; split-file %s %t
# RUN: ln -s Versions/A/Developer %t/Developer/Library/Frameworks/Developer.framework/
# RUN: llvm-mc -filetype obj -triple arm64-apple-macos11.0 %t/test.s -o %t/test.o
Expand Down
4 changes: 3 additions & 1 deletion lld/test/MachO/reexport-without-rpath.s
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
# REQUIRES: aarch64, shell
# REQUIRES: aarch64
# Windows does not support rpath
# UNSUPPORTED: system-windows
# RUN: rm -rf %t; split-file %s %t
# RUN: ln -s Versions/A/Developer %t/Developer/Library/Frameworks/Developer.framework/
# RUN: ln -s Versions/A/DeveloperCore %t/Developer/Library/PrivateFrameworks/DeveloperCore.framework/
Expand Down
4 changes: 3 additions & 1 deletion lld/test/MachO/reproduce.s
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
# REQUIRES: x86, shell
# REQUIRES: x86_64
# Unsupported on Windows due to maximum path length limitations.
# UNSUPPORTED: system-windows

# RUN: rm -rf %t.dir
# RUN: mkdir -p %t.dir/build1
Expand Down
4 changes: 3 additions & 1 deletion lld/test/MachO/tapi-rpath.s
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
# REQUIRES: aarch64, shell
# REQUIRES: aarch64
# Windows does not support rpath
# UNSUPPORTED: system-windows
# RUN: rm -rf %t; split-file %s %t
# RUN: ln -s Versions/A/Developer %t/Developer/Library/Frameworks/Developer.framework/
# RUN: ln -s Versions/A/DeveloperCore %t/Developer/Library/PrivateFrameworks/DeveloperCore.framework/
Expand Down
3 changes: 2 additions & 1 deletion lld/test/wasm/reproduce.s
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# REQUIRES: shell
# Unsupported on Windows due to maximum path length limitations.
Copy link
Collaborator

@sbc100 sbc100 Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any long pathnames in this test, but maybe I'm missing something?

Maybe its use the file stdin? FileCheck --check-prefix=RSP %s < repro/response.txt ?

Copy link
Contributor Author

@boomanaiden154 boomanaiden154 Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They theoretically come from unpacking repro.tar. I just saw all the reproduce.s tests had shell requirements and assume they came from (at least cargo culting) cbe62f2. I didn't want to try and remove too many to avoid buildbot churn. Happy to review a PR reenabling this on Windows though if you think that works and it passes premerge.

Copy link
Collaborator

@sbc100 sbc100 Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see, yes it does seem like the issue is that tar itself was failing to unpack the archive. I guess cbe62f2 is correct and this comment does make sense.

Copy link
Member

@compnerd compnerd Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the bundled tar on windows might extract to long paths? Worth a check.

# UNSUPPORTED: system-windows
# RUN: rm -rf %t.dir
# RUN: mkdir -p %t.dir
# RUN: llvm-mc -filetype=obj -triple=wasm32-unknown-unknown -o %t.dir/foo.o %s
Expand Down
Loading