Skip to content

[lldb][NativePDB] Sort function name and type basename maps deterministically. #156530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 2, 2025
Merged

[lldb][NativePDB] Sort function name and type basename maps deterministically. #156530

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca5ad06
[lldb][NativePDB] Sort function name maps deterministically.
ZequanWu Sep 2, 2025
e7d0ac5
Sort m_type_base_names deterministically as well.
ZequanWu Sep 2, 2025
c9125b1
Merge branch 'main' into sort
ZequanWu Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1735,11 +1735,11 @@ void SymbolFileNativePDB::CacheFunctionNames() {
}

// Sort them before value searching is working properly.
m_func_full_names.Sort();
m_func_full_names.Sort(std::less<uint32_t>());
m_func_full_names.SizeToFit();
m_func_method_names.Sort();
m_func_method_names.Sort(std::less<uint32_t>());
m_func_method_names.SizeToFit();
m_func_base_names.Sort();
m_func_base_names.Sort(std::less<uint32_t>());
m_func_base_names.SizeToFit();
}

Expand Down Expand Up @@ -2426,7 +2426,7 @@ void SymbolFileNativePDB::BuildParentMap() {

// After calling Append(), the type-name map needs to be sorted again to be
// able to look up a type by its name.
m_type_base_names.Sort();
m_type_base_names.Sort(std::less<uint32_t>());

// Now that we know the forward -> full mapping of all type indices, we can
// re-write all the indices. At the end of this process, we want a mapping
Expand Down
Loading