Skip to content

[clang-tidy] Fix readability-uppercase-literal-suffix warning with hex literals #156584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2025
Merged

[clang-tidy] Fix readability-uppercase-literal-suffix warning with hex literals #156584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clang-tools-extra/clang-tidy/readability/UppercaseLiteralSuffixCheck.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ struct IntegerLiteralCheck {
// integer (wb), and can be a complex number ('i', 'j'). In MS compatibility
// mode, suffixes like i32 are supported.
static constexpr llvm::StringLiteral Suffixes =
llvm::StringLiteral("uUlLzZwWbBiIjJ");
llvm::StringLiteral("uUlLzZwWiIjJ");
};

struct FloatingLiteralCheck {
Expand Down
9 changes: 9 additions & 0 deletions clang-tools-extra/test/clang-tidy/checkers/cert/uppercase-literal-suffix-integer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,3 +128,12 @@ void integer_suffix() {
static_assert(is_same<decltype(v24), const unsigned long long>::value, "");
static_assert(v24 == 1, "");
}

void no_warning_on_hex_literals() {
int a = 0xa;
int b = 0xb;
int c = 0xc;
int d = 0xd;
int e = 0xe;
int f = 0xf;
}
Loading