Skip to content

[X86][GlobalIsel] Support G_INTRINSIC_TRUNC/G_FCEIL/G_FFLOOR #156633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 15, 2025
+135 −23
Merged

[X86][GlobalIsel] Support G_INTRINSIC_TRUNC/G_FCEIL/G_FFLOOR #156633

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c9b41e4
add gisel output
Sep 3, 2025
7fa4c15
update gisel2
Sep 3, 2025
193fb0b
update test
Sep 3, 2025
3cce02f
fix tesT
Sep 3, 2025
21d6ab9
address review comments
Sep 7, 2025
7894b05
Merge branch 'main' into gisel_floor_trunc_ceil
mahesh-attarde Sep 9, 2025
a0f361b
opt test
mahesh-attarde Sep 9, 2025
6f3c4ff
Merge branch 'main' into gisel_floor_trunc_ceil
RKSimon Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion llvm/lib/Target/X86/GISel/X86LegalizerInfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,7 +580,8 @@ X86LegalizerInfo::X86LegalizerInfo(const X86Subtarget &STI,
.lower();

// fp intrinsics
getActionDefinitionsBuilder(G_INTRINSIC_ROUNDEVEN)
getActionDefinitionsBuilder(
{G_INTRINSIC_ROUNDEVEN, G_INTRINSIC_TRUNC, G_FCEIL, G_FFLOOR})
.scalarize(0)
.minScalar(0, LLT::scalar(32))
.libcall();
Expand Down
34 changes: 11 additions & 23 deletions llvm/test/CodeGen/X86/isel-ceil.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
; RUN: llc < %s -mtriple=x86_64-linux-gnu -fast-isel | FileCheck %s --check-prefixes=X64,FASTISEL-X64
; RUN: llc < %s -mtriple=i686-linux-gnu | FileCheck %s --check-prefixes=X86
; RUN: llc < %s -mtriple=i686-linux-gnu -fast-isel | FileCheck %s --check-prefixes=X86
; RUN: llc < %s -mtriple=x86_64-linux-gnu -global-isel -global-isel-abort=2 | FileCheck %s --check-prefixes=GISEL-X64
; RUN: llc < %s -mtriple=i686-linux-gnu -global-isel -global-isel-abort=2 | FileCheck %s --check-prefixes=X86
; RUN: llc < %s -mtriple=x86_64-linux-gnu -global-isel -global-isel-abort=1 | FileCheck %s --check-prefixes=GISEL-X64
; RUN: llc < %s -mtriple=i686-linux-gnu -global-isel -global-isel-abort=1 | FileCheck %s --check-prefixes=X86

define float @ceil_f32(float %a) nounwind readnone {
; DAG-X64-LABEL: ceil_f32:
Expand All @@ -18,18 +18,12 @@ define float @ceil_f32(float %a) nounwind readnone {
; FASTISEL-X64-NEXT: popq %rax
; FASTISEL-X64-NEXT: retq
;
; X86-LABEL: ceil_f32:
; X86: # %bb.0:
; X86-NEXT: subl $12, %esp
; X86-NEXT: flds {{[0-9]+}}(%esp)
; X86-NEXT: fstps (%esp)
; X86-NEXT: calll ceilf
; X86-NEXT: addl $12, %esp
; X86-NEXT: retl
;
; GISEL-X64-LABEL: ceil_f32:
; GISEL-X64: # %bb.0:
; GISEL-X64-NEXT: jmp ceilf@PLT # TAILCALL
; GISEL-X64-NEXT: pushq %rax
; GISEL-X64-NEXT: callq ceilf
; GISEL-X64-NEXT: popq %rax
; GISEL-X64-NEXT: retq
%c = call float @llvm.ceil.f32(float %a)
ret float %c
}
Expand All @@ -46,18 +40,12 @@ define double @ceil_f64(double %a) nounwind readnone {
; FASTISEL-X64-NEXT: popq %rax
; FASTISEL-X64-NEXT: retq
;
; X86-LABEL: ceil_f64:
; X86: # %bb.0:
; X86-NEXT: subl $12, %esp
; X86-NEXT: fldl {{[0-9]+}}(%esp)
; X86-NEXT: fstpl (%esp)
; X86-NEXT: calll ceil
; X86-NEXT: addl $12, %esp
; X86-NEXT: retl
;
; GISEL-X64-LABEL: ceil_f64:
; GISEL-X64: # %bb.0:
; GISEL-X64-NEXT: jmp ceil@PLT # TAILCALL
; GISEL-X64-NEXT: pushq %rax
; GISEL-X64-NEXT: callq ceil
; GISEL-X64-NEXT: popq %rax
; GISEL-X64-NEXT: retq
%c = call double @llvm.ceil.f64(double %a)
ret double %c
}
Expand Down Expand Up @@ -86,7 +74,7 @@ define x86_fp80 @ceil_f80(x86_fp80 %a) nounwind readnone {
; GISEL-X64-NEXT: subq $24, %rsp
; GISEL-X64-NEXT: fldt {{[0-9]+}}(%rsp)
; GISEL-X64-NEXT: fstpt (%rsp)
; GISEL-X64-NEXT: callq ceill@PLT
; GISEL-X64-NEXT: callq ceill
; GISEL-X64-NEXT: addq $24, %rsp
; GISEL-X64-NEXT: retq
%c = call x86_fp80 @llvm.ceil.f80(x86_fp80 %a)
Expand Down
34 changes: 11 additions & 23 deletions llvm/test/CodeGen/X86/isel-floor.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
; RUN: llc < %s -mtriple=x86_64-linux-gnu -fast-isel | FileCheck %s --check-prefixes=X64,FASTISEL-X64
; RUN: llc < %s -mtriple=i686-linux-gnu | FileCheck %s --check-prefixes=X86
; RUN: llc < %s -mtriple=i686-linux-gnu -fast-isel | FileCheck %s --check-prefixes=X86
; RUN: llc < %s -mtriple=x86_64-linux-gnu -global-isel -global-isel-abort=2 | FileCheck %s --check-prefixes=GISEL-X64
; RUN: llc < %s -mtriple=i686-linux-gnu -global-isel -global-isel-abort=2 | FileCheck %s --check-prefixes=X86
; RUN: llc < %s -mtriple=x86_64-linux-gnu -global-isel -global-isel-abort=1 | FileCheck %s --check-prefixes=GISEL-X64
; RUN: llc < %s -mtriple=i686-linux-gnu -global-isel -global-isel-abort=1 | FileCheck %s --check-prefixes=X86

define float @floor_f32(float %a) nounwind readnone {
; DAG-X64-LABEL: floor_f32:
Expand All @@ -18,18 +18,12 @@ define float @floor_f32(float %a) nounwind readnone {
; FASTISEL-X64-NEXT: popq %rax
; FASTISEL-X64-NEXT: retq
;
; X86-LABEL: floor_f32:
; X86: # %bb.0:
; X86-NEXT: subl $12, %esp
; X86-NEXT: flds {{[0-9]+}}(%esp)
; X86-NEXT: fstps (%esp)
; X86-NEXT: calll floorf
; X86-NEXT: addl $12, %esp
; X86-NEXT: retl
;
; GISEL-X64-LABEL: floor_f32:
; GISEL-X64: # %bb.0:
; GISEL-X64-NEXT: jmp floorf@PLT # TAILCALL
; GISEL-X64-NEXT: pushq %rax
; GISEL-X64-NEXT: callq floorf
; GISEL-X64-NEXT: popq %rax
; GISEL-X64-NEXT: retq
%c = call float @llvm.floor.f32(float %a)
ret float %c
}
Expand All @@ -46,18 +40,12 @@ define double @floor_f64(double %a) nounwind readnone {
; FASTISEL-X64-NEXT: popq %rax
; FASTISEL-X64-NEXT: retq
;
; X86-LABEL: floor_f64:
; X86: # %bb.0:
; X86-NEXT: subl $12, %esp
; X86-NEXT: fldl {{[0-9]+}}(%esp)
; X86-NEXT: fstpl (%esp)
; X86-NEXT: calll floor
; X86-NEXT: addl $12, %esp
; X86-NEXT: retl
;
; GISEL-X64-LABEL: floor_f64:
; GISEL-X64: # %bb.0:
; GISEL-X64-NEXT: jmp floor@PLT # TAILCALL
; GISEL-X64-NEXT: pushq %rax
; GISEL-X64-NEXT: callq floor
; GISEL-X64-NEXT: popq %rax
; GISEL-X64-NEXT: retq
%c = call double @llvm.floor.f64(double %a)
ret double %c
}
Expand Down Expand Up @@ -86,7 +74,7 @@ define x86_fp80 @floor_f80(x86_fp80 %a) nounwind readnone {
; GISEL-X64-NEXT: subq $24, %rsp
; GISEL-X64-NEXT: fldt {{[0-9]+}}(%rsp)
; GISEL-X64-NEXT: fstpt (%rsp)
; GISEL-X64-NEXT: callq floorl@PLT
; GISEL-X64-NEXT: callq floorl
; GISEL-X64-NEXT: addq $24, %rsp
; GISEL-X64-NEXT: retq
%c = call x86_fp80 @llvm.floor.f80(x86_fp80 %a)
Expand Down
34 changes: 11 additions & 23 deletions llvm/test/CodeGen/X86/isel-ftrunc.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
; RUN: llc < %s -mtriple=x86_64-linux-gnu -fast-isel | FileCheck %s --check-prefixes=X64,FASTISEL-X64
; RUN: llc < %s -mtriple=i686-linux-gnu | FileCheck %s --check-prefixes=X86
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
; RUN: llc < %s -mtriple=i686-linux-gnu | FileCheck %s --check-prefixes=X86
; RUN: llc < %s -mtriple=i686-linux-gnu | FileCheck %s --check-prefixes=X86,DAG-X86

; RUN: llc < %s -mtriple=i686-linux-gnu -fast-isel | FileCheck %s --check-prefixes=X86
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
; RUN: llc < %s -mtriple=i686-linux-gnu -fast-isel | FileCheck %s --check-prefixes=X86
; RUN: llc < %s -mtriple=i686-linux-gnu -fast-isel | FileCheck %s --check-prefixes=X86,FASTISEL-X86

; RUN: llc < %s -mtriple=x86_64-linux-gnu -global-isel -global-isel-abort=2 | FileCheck %s --check-prefixes=GISEL-X64
; RUN: llc < %s -mtriple=i686-linux-gnu -global-isel -global-isel-abort=2 | FileCheck %s --check-prefixes=X86
; RUN: llc < %s -mtriple=x86_64-linux-gnu -global-isel -global-isel-abort=1 | FileCheck %s --check-prefixes=GISEL-X64
; RUN: llc < %s -mtriple=i686-linux-gnu -global-isel -global-isel-abort=1 | FileCheck %s --check-prefixes=X86

define float @trunc_f32(float %a) nounwind readnone {
; DAG-X64-LABEL: trunc_f32:
Expand All @@ -18,18 +18,12 @@ define float @trunc_f32(float %a) nounwind readnone {
; FASTISEL-X64-NEXT: popq %rax
; FASTISEL-X64-NEXT: retq
;
; X86-LABEL: trunc_f32:
; X86: # %bb.0:
; X86-NEXT: subl $12, %esp
; X86-NEXT: flds {{[0-9]+}}(%esp)
; X86-NEXT: fstps (%esp)
; X86-NEXT: calll truncf
; X86-NEXT: addl $12, %esp
; X86-NEXT: retl
;
; GISEL-X64-LABEL: trunc_f32:
; GISEL-X64: # %bb.0:
; GISEL-X64-NEXT: jmp truncf@PLT # TAILCALL
; GISEL-X64-NEXT: pushq %rax
; GISEL-X64-NEXT: callq truncf
; GISEL-X64-NEXT: popq %rax
; GISEL-X64-NEXT: retq
%c = call float @llvm.trunc.f32(float %a)
ret float %c
}
Expand All @@ -46,18 +40,12 @@ define double @trunc_f64(double %a) nounwind readnone {
; FASTISEL-X64-NEXT: popq %rax
; FASTISEL-X64-NEXT: retq
;
; X86-LABEL: trunc_f64:
; X86: # %bb.0:
; X86-NEXT: subl $12, %esp
; X86-NEXT: fldl {{[0-9]+}}(%esp)
; X86-NEXT: fstpl (%esp)
; X86-NEXT: calll trunc
; X86-NEXT: addl $12, %esp
; X86-NEXT: retl
;
; GISEL-X64-LABEL: trunc_f64:
; GISEL-X64: # %bb.0:
; GISEL-X64-NEXT: jmp trunc@PLT # TAILCALL
; GISEL-X64-NEXT: pushq %rax
; GISEL-X64-NEXT: callq trunc
; GISEL-X64-NEXT: popq %rax
; GISEL-X64-NEXT: retq
%c = call double @llvm.trunc.f64(double %a)
ret double %c
}
Expand Down Expand Up @@ -86,7 +74,7 @@ define x86_fp80 @trunc_f80(x86_fp80 %a) nounwind readnone {
; GISEL-X64-NEXT: subq $24, %rsp
; GISEL-X64-NEXT: fldt {{[0-9]+}}(%rsp)
; GISEL-X64-NEXT: fstpt (%rsp)
; GISEL-X64-NEXT: callq truncl@PLT
; GISEL-X64-NEXT: callq truncl
; GISEL-X64-NEXT: addq $24, %rsp
; GISEL-X64-NEXT: retq
%c = call x86_fp80 @llvm.trunc.f80(x86_fp80 %a)
Expand Down
Loading