Skip to content

[clang-repl] Reimplement value printing using MemoryAccess to support in-process and out-of-process #156649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

[clang-repl] Reimplement value printing using MemoryAccess to support in-process and out-of-process #156649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
456b66b
[clang-repl] Reimplement value printing using MemoryAccess to support…
SahilPatidar Sep 2, 2025
dcdf61c
Fix issues and add ValueToString helper
SahilPatidar Sep 3, 2025
7ae5095
Rebased
SahilPatidar Sep 6, 2025
d540221
Fix some issues
SahilPatidar Sep 8, 2025
243331f
Introduce new Value class design, inspired by APValue
SahilPatidar Sep 12, 2025
58d4109
Introduce ValueCleanup for managed destruction of JIT values
SahilPatidar Sep 13, 2025
4b9539e
Refactor code and headers
SahilPatidar Sep 14, 2025
f1e5456
Fix some issues
SahilPatidar Sep 15, 2025
190a591
Fix issues
SahilPatidar Sep 15, 2025
e56b4f3
Rebase and add assertion in ValueCleanup()
SahilPatidar Sep 15, 2025
6d7082e
Make Value's destructor safe by updating ArrValue and StrValue
SahilPatidar Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions clang/include/clang/Interpreter/Interpreter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,10 +109,7 @@ class Interpreter {

unsigned InitPTUSize = 0;

// This member holds the last result of the value printing. It's a class
// member because we might want to access it after more inputs. If no value
// printing happens, it's in an invalid state.
Value LastValue;
std::unique_ptr<ValueResultManager> ValMgr;

/// Compiler instance performing the incremental compilation.
std::unique_ptr<CompilerInstance> CI;
Expand Down Expand Up @@ -221,14 +218,7 @@ class Interpreter {

std::unique_ptr<llvm::orc::LLJITBuilder> JITBuilder;

/// @}
/// @name Value and pretty printing support
/// @{

std::string ValueDataToString(const Value &V) const;
std::string ValueTypeToString(const Value &V) const;

llvm::Expected<Expr *> convertExprToValue(Expr *E);
llvm::Expected<Expr *> convertExprToValue(Expr *E, bool IsOOP = false);

// When we deallocate clang::Value we need to run the destructor of the type.
// This function forces emission of the needed dtor.
Expand Down
Loading
Loading