Skip to content

[OpenMP] Fix: Add missing preprocessor guard for hwloc types on macOS #156708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
+2 −1
Closed

[OpenMP] Fix: Add missing preprocessor guard for hwloc types on macOS #156708

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9d9557
Fix: Add missing preprocessor guard for hwloc types on macOS
Sep 3, 2025
9da72be
Merge branch 'main' into fix/macos-openmp-build-error
Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion openmp/runtime/src/kmp_alloc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1545,7 +1545,7 @@ void __kmp_fini_memkind() {
#endif
}

#if KMP_USE_HWLOC
#if KMP_USE_HWLOC && KMP_AFFINITY_SUPPORTED
static bool __kmp_is_hwloc_membind_supported(hwloc_membind_policy_t policy) {
#if HWLOC_API_VERSION >= 0x00020300
const hwloc_topology_support *support;
Expand All @@ -1563,6 +1563,7 @@ static bool __kmp_is_hwloc_membind_supported(hwloc_membind_policy_t policy) {
return false;
#endif
}
#endif
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks wrong. The #if above was already there, so adding an extra #endif will definitely break something.


void *__kmp_hwloc_alloc_membind(hwloc_memattr_id_e attr, size_t size,
hwloc_membind_policy_t policy) {
Expand Down
Loading