-
Notifications
You must be signed in to change notification settings - Fork 14.9k
[LV]: Improve accuracy of calculating remaining iterations of MainLoopVF #156723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4372,11 +4372,24 @@ VectorizationFactor LoopVectorizationPlanner::selectEpilogueVectorizationFactor( | |
const SCEV *TC = | ||
vputils::getSCEVExprForVPValue(getPlanFor(MainLoopVF).getTripCount(), SE); | ||
assert(!isa<SCEVCouldNotCompute>(TC) && "Trip count SCEV must be computable"); | ||
RemainingIterations = | ||
SE.getURemExpr(TC, SE.getElementCount(TCType, MainLoopVF * IC)); | ||
const SCEV *KnownMinTC; | ||
bool ScalableTC = match(TC, m_scev_Mul(m_SCEV(KnownMinTC), m_SCEVVScale())) || | ||
match(TC, m_scev_Mul(m_SCEVVScale(), m_SCEV(KnownMinTC))); | ||
// Use versions of TC and VF in which both are either scalable or fixed. | ||
if (ScalableTC == MainLoopVF.isScalable()) { | ||
RemainingIterations = | ||
SE.getURemExpr(TC, SE.getElementCount(TCType, MainLoopVF * IC)); | ||
} else { | ||
if (ScalableTC) | ||
|
||
RemainingIterations = SE.getURemExpr( | ||
KnownMinTC, SE.getElementCount(TCType, MainLoopVF * IC)); | ||
|
||
else | ||
RemainingIterations = SE.getURemExpr( | ||
TC, SE.getElementCount(TCType, EstimatedRuntimeVF * IC)); | ||
} | ||
|
||
// No iterations left to process in the epilogue. | ||
if (RemainingIterations->isZero()) | ||
if (!RemainingIterations || RemainingIterations->isZero()) | ||
|
||
return Result; | ||
|
||
if (MainLoopVF.isFixed()) { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.