Skip to content

Conversation

@joker-eph
Copy link
Collaborator

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Sep 3, 2025

@llvm/pr-subscribers-mlir

Author: Mehdi Amini (joker-eph)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/156748.diff

1 Files Affected:

  • (modified) mlir/lib/Target/SPIRV/Serialization/Serializer.cpp (+4-4)
diff --git a/mlir/lib/Target/SPIRV/Serialization/Serializer.cpp b/mlir/lib/Target/SPIRV/Serialization/Serializer.cpp
index 7fc779587f4f1..fca686accd96f 100644
--- a/mlir/lib/Target/SPIRV/Serialization/Serializer.cpp
+++ b/mlir/lib/Target/SPIRV/Serialization/Serializer.cpp
@@ -818,8 +818,8 @@ LogicalResult Serializer::prepareBasicType(
 
       bool shaped = llvm::all_of(dims, [](const auto &dim) { return dim > 0; });
       if (rank > 0 && shaped) {
-        auto I32Type = IntegerType::get(type.getContext(), 32);
-        auto shapeType = ArrayType::get(I32Type, rank);
+        auto i32Type = IntegerType::get(type.getContext(), 32);
+        auto shapeType = ArrayType::get(i32Type, rank);
         if (rank == 1) {
           SmallVector<uint64_t, 1> index(rank);
           shapeID = prepareDenseElementsConstant(
@@ -1368,8 +1368,8 @@ LogicalResult Serializer::emitPhiForBlockArguments(Block *block) {
     }
     LLVM_DEBUG({
       llvm::dbgs() << "    block arguments:\n";
-      for (Value v : predecessors.back().second)
-        llvm::dbgs() << "      " << v << "\n";
+      for (Value V : predecessors.back().second)
+        llvm::dbgs() << "      " << V << "\n";
     });
   }
 

@llvmbot
Copy link
Member

llvmbot commented Sep 3, 2025

@llvm/pr-subscribers-mlir-spirv

Author: Mehdi Amini (joker-eph)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/156748.diff

1 Files Affected:

  • (modified) mlir/lib/Target/SPIRV/Serialization/Serializer.cpp (+4-4)
diff --git a/mlir/lib/Target/SPIRV/Serialization/Serializer.cpp b/mlir/lib/Target/SPIRV/Serialization/Serializer.cpp
index 7fc779587f4f1..fca686accd96f 100644
--- a/mlir/lib/Target/SPIRV/Serialization/Serializer.cpp
+++ b/mlir/lib/Target/SPIRV/Serialization/Serializer.cpp
@@ -818,8 +818,8 @@ LogicalResult Serializer::prepareBasicType(
 
       bool shaped = llvm::all_of(dims, [](const auto &dim) { return dim > 0; });
       if (rank > 0 && shaped) {
-        auto I32Type = IntegerType::get(type.getContext(), 32);
-        auto shapeType = ArrayType::get(I32Type, rank);
+        auto i32Type = IntegerType::get(type.getContext(), 32);
+        auto shapeType = ArrayType::get(i32Type, rank);
         if (rank == 1) {
           SmallVector<uint64_t, 1> index(rank);
           shapeID = prepareDenseElementsConstant(
@@ -1368,8 +1368,8 @@ LogicalResult Serializer::emitPhiForBlockArguments(Block *block) {
     }
     LLVM_DEBUG({
       llvm::dbgs() << "    block arguments:\n";
-      for (Value v : predecessors.back().second)
-        llvm::dbgs() << "      " << v << "\n";
+      for (Value V : predecessors.back().second)
+        llvm::dbgs() << "      " << V << "\n";
     });
   }
 

@joker-eph joker-eph closed this Sep 3, 2025
@joker-eph joker-eph deleted the tidy branch September 3, 2025 20:15
@joker-eph joker-eph restored the tidy branch September 3, 2025 20:19
@joker-eph joker-eph deleted the tidy branch September 3, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants