Skip to content

[NFC][IntrinsicEmitter] Include source location with enum definition #156800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jurahul merged 1 commit into from
Sep 4, 2025
Merged

[NFC][IntrinsicEmitter] Include source location with enum definition #156800

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions llvm/utils/TableGen/Basic/IntrinsicEmitter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
#include "llvm/Support/ErrorHandling.h"
#include "llvm/Support/FormatVariadic.h"
#include "llvm/Support/ModRef.h"
#include "llvm/Support/SourceMgr.h"
#include "llvm/Support/raw_ostream.h"
#include "llvm/TableGen/Error.h"
#include "llvm/TableGen/Record.h"
Expand Down Expand Up @@ -154,7 +155,7 @@ void IntrinsicEmitter::EmitEnumInfo(const CodeGenIntrinsicTable &Ints,

OS << "// Enum values for intrinsics.\n";
bool First = true;
for (const auto &Int : Ints[*Set]) {
for (const CodeGenIntrinsic &Int : Ints[*Set]) {
OS << " " << Int.EnumName;

// Assign a value to the first intrinsic in this target set so that all
Expand All @@ -167,7 +168,9 @@ void IntrinsicEmitter::EmitEnumInfo(const CodeGenIntrinsicTable &Ints,
OS << ", ";
if (Int.EnumName.size() < 40)
OS.indent(40 - Int.EnumName.size());
OS << formatv(" // {}\n", Int.Name);
OS << formatv(
" // {} ({})\n", Int.Name,
SrcMgr.getFormattedLocationNoOffset(Int.TheDef->getLoc().front()));
}

// Emit num_intrinsics into the target neutral enum.
Expand Down