Skip to content

[Support] Make shouldReverseIterate constexpr #156812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kazutakahirata merged 2 commits into from
Sep 4, 2025
Merged

[Support] Make shouldReverseIterate constexpr #156812

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3985d8f
[Support] Use "if constexpr" in shouldReverseIterate
kazutakahirata Sep 3, 2025
41a94f2
Address a comment.
kazutakahirata Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions llvm/include/llvm/Support/ReverseIteration.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,11 @@

namespace llvm {

template<class T = void *>
bool shouldReverseIterate() {
#if LLVM_ENABLE_REVERSE_ITERATION
return detail::IsPointerLike<T>::value;
#else
return false;
#endif
template <class T = void *> constexpr bool shouldReverseIterate() {
if constexpr (LLVM_ENABLE_REVERSE_ITERATION)
return detail::IsPointerLike<T>::value;
else
return false;
}

} // namespace llvm
Expand Down