[Clang][Sema] Extend test coverage for SVE/SME builtin usage. #156908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulwalker-arm
requested review from
huntergr-arm,
sdesmalen-arm and
kmclaughlin-arm
llvmbot
added
clang
|
@llvm/pr-subscribers-clang @llvm/pr-subscribers-backend-aarch64 Author: Paul Walker (paulwalker-arm) ChangesAdds SEMA tests to verify correct SVE/SME builtin usage based on the calling function's type (i.e. normal, streaming or streaming compatible). For invalid uses the tests verify the expected diagnostic is emitted. This exposed an issue whereby some builtins are incorrectly callable by streaming compatible functions, which this PR fixes. The tests are autogenerated based on the builtin definitions (e.g. arm_sve.td). This is achieved by extending SVEEmitter, which can now emit a JSON file containing builtin usage information that can be fed to aarch64_builtins_test_generator.py that is also part of this PR. Everything currently in Patch is 4.27 MiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/156908.diff 68 Files Affected:
diff --git a/clang/include/clang/Basic/CMakeLists.txt b/clang/include/clang/Basic/CMakeLists.txt
index 81736006a21a0..cfd165e6fa7e1 100644
--- a/clang/include/clang/Basic/CMakeLists.txt
+++ b/clang/include/clang/Basic/CMakeLists.txt
@@ -159,6 +159,9 @@ clang_tablegen(arm_mve_builtin_aliases.inc -gen-arm-mve-builtin-aliases
clang_tablegen(arm_sve_builtins.inc -gen-arm-sve-builtins
SOURCE arm_sve.td
TARGET ClangARMSveBuiltins)
+clang_tablegen(arm_sve_builtins.json -gen-arm-sve-builtins-json
+ SOURCE arm_sve.td
+ TARGET ClangARMSveBuiltinsJSON)
clang_tablegen(arm_sve_builtin_cg.inc -gen-arm-sve-builtin-codegen
SOURCE arm_sve.td
TARGET ClangARMSveBuiltinCG)
@@ -174,6 +177,9 @@ clang_tablegen(arm_sve_streaming_attrs.inc -gen-arm-sve-streaming-attrs
clang_tablegen(arm_sme_builtins.inc -gen-arm-sme-builtins
SOURCE arm_sme.td
TARGET ClangARMSmeBuiltins)
+clang_tablegen(arm_sme_builtins.json -gen-arm-sme-builtins-json
+ SOURCE arm_sme.td
+ TARGET ClangARMSmeBuiltinsJSON)
clang_tablegen(arm_sme_builtin_cg.inc -gen-arm-sme-builtin-codegen
SOURCE arm_sme.td
TARGET ClangARMSmeBuiltinCG)
diff --git a/clang/lib/Sema/SemaARM.cpp b/clang/lib/Sema/SemaARM.cpp
index e09c35296ef3b..1c7c832d7edfa 100644
--- a/clang/lib/Sema/SemaARM.cpp
+++ b/clang/lib/Sema/SemaARM.cpp
@@ -603,8 +603,8 @@ static bool checkArmStreamingBuiltin(Sema &S, CallExpr *TheCall,
bool SatisfiesSME = Builtin::evaluateRequiredTargetFeatures(
StreamingBuiltinGuard, CallerFeatures);
- if ((SatisfiesSVE && SatisfiesSME) ||
- (SatisfiesSVE && FnType == SemaARM::ArmStreamingCompatible))
+ if (SatisfiesSVE && SatisfiesSME)
+ // Function type is irrelevant for streaming-agnostic builtins.
return false;
else if (SatisfiesSVE)
BuiltinType = SemaARM::ArmNonStreaming;
diff --git a/clang/test/CodeGen/AArch64/sve2-intrinsics/acle_sve2_rax1.c b/clang/test/CodeGen/AArch64/sve2-intrinsics/acle_sve2_rax1.c
index 42bc37b9ef17c..480d4e4744f0a 100644
--- a/clang/test/CodeGen/AArch64/sve2-intrinsics/acle_sve2_rax1.c
+++ b/clang/test/CodeGen/AArch64/sve2-intrinsics/acle_sve2_rax1.c
@@ -1,10 +1,9 @@
// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
-// RUN: %clang_cc1 -fclang-abi-compat=latest -triple aarch64 -target-feature +sve -target-feature +sve2 -target-feature +sve-sha3 -O1 -Werror -Wall -emit-llvm -o - %s | FileCheck %s
-// RUN: %clang_cc1 -fclang-abi-compat=latest -triple aarch64 -target-feature +sme -target-feature +sme2 -target-feature +sme2p1 -target-feature +sve-sha3 -O1 -Werror -Wall -emit-llvm -o - %s | FileCheck %s
-// RUN: %clang_cc1 -fclang-abi-compat=latest -triple aarch64 -target-feature +sve -target-feature +sve2 -target-feature +sme2p1 -target-feature +sve-sha3 -O1 -Werror -Wall -emit-llvm -o - %s | FileCheck %s
-// RUN: %clang_cc1 -fclang-abi-compat=latest -triple aarch64 -target-feature +sve -target-feature +sve2 -target-feature +sve-sha3 -O1 -Werror -Wall -emit-llvm -o - -x c++ %s | FileCheck %s -check-prefix=CPP-CHECK
-// RUN: %clang_cc1 -fclang-abi-compat=latest -DSVE_OVERLOADED_FORMS -triple aarch64 -target-feature +sve -target-feature +sve2 -target-feature +sve-sha3 -O1 -Werror -Wall -emit-llvm -o - %s | FileCheck %s
-// RUN: %clang_cc1 -fclang-abi-compat=latest -DSVE_OVERLOADED_FORMS -triple aarch64 -target-feature +sve -target-feature +sve2 -target-feature +sve-sha3 -O1 -Werror -Wall -emit-llvm -o - -x c++ %s | FileCheck %s -check-prefix=CPP-CHECK
+// RUN: %clang_cc1 -fclang-abi-compat=latest -triple aarch64 -target-feature +sve -target-feature +sve-sha3 -O1 -Werror -Wall -emit-llvm -o - %s | FileCheck %s
+// RUN: %clang_cc1 -fclang-abi-compat=latest -triple aarch64 -target-feature +sme -target-feature +sme2p1 -target-feature +sve-sha3 -O1 -Werror -Wall -emit-llvm -o - %s | FileCheck %s
+// RUN: %clang_cc1 -fclang-abi-compat=latest -triple aarch64 -target-feature +sve -target-feature +sve-sha3 -O1 -Werror -Wall -emit-llvm -o - -x c++ %s | FileCheck %s -check-prefix=CPP-CHECK
+// RUN: %clang_cc1 -fclang-abi-compat=latest -DSVE_OVERLOADED_FORMS -triple aarch64 -target-feature +sve -target-feature +sve-sha3 -O1 -Werror -Wall -emit-llvm -o - %s | FileCheck %s
+// RUN: %clang_cc1 -fclang-abi-compat=latest -DSVE_OVERLOADED_FORMS -triple aarch64 -target-feature +sve -target-feature +sve-sha3 -O1 -Werror -Wall -emit-llvm -o - -x c++ %s | FileCheck %s -check-prefix=CPP-CHECK
// REQUIRES: aarch64-registered-target
diff --git a/clang/test/Sema/AArch64/arm_sme_streaming_compatible_sme.c b/clang/test/Sema/AArch64/arm_sme_streaming_compatible_sme.c
new file mode 100644
index 0000000000000..f695e278d91ad
--- /dev/null
+++ b/clang/test/Sema/AArch64/arm_sme_streaming_compatible_sme.c
@@ -0,0 +1,48 @@
+// NOTE: File has been autogenerated by utils/aarch64_builtins_test_generator.py
+// RUN: %clang_cc1 %s -fsyntax-only -triple aarch64-none-linux-gnu -target-feature +sme -verify
+// expected-no-diagnostics
+
+// REQUIRES: aarch64-registered-target
+
+#include <arm_sme.h>
+
+// Properties: guard="" streaming_guard="sme" flags="streaming-compatible,requires-za"
+
+void test(void) __arm_inout("za"){
+ int64_t int64_t_val;
+ uint32_t uint32_t_val;
+ void * void_ptr_val;
+
+ svldr_vnum_za(uint32_t_val, void_ptr_val, int64_t_val);
+ svldr_za(uint32_t_val, void_ptr_val);
+ svstr_vnum_za(uint32_t_val, void_ptr_val, int64_t_val);
+ svstr_za(uint32_t_val, void_ptr_val);
+ svzero_mask_za(2);
+ svzero_za();
+}
+
+void test_streaming(void) __arm_streaming __arm_inout("za"){
+ int64_t int64_t_val;
+ uint32_t uint32_t_val;
+ void * void_ptr_val;
+
+ svldr_vnum_za(uint32_t_val, void_ptr_val, int64_t_val);
+ svldr_za(uint32_t_val, void_ptr_val);
+ svstr_vnum_za(uint32_t_val, void_ptr_val, int64_t_val);
+ svstr_za(uint32_t_val, void_ptr_val);
+ svzero_mask_za(2);
+ svzero_za();
+}
+
+void test_streaming_compatible(void) __arm_streaming_compatible __arm_inout("za"){
+ int64_t int64_t_val;
+ uint32_t uint32_t_val;
+ void * void_ptr_val;
+
+ svldr_vnum_za(uint32_t_val, void_ptr_val, int64_t_val);
+ svldr_za(uint32_t_val, void_ptr_val);
+ svstr_vnum_za(uint32_t_val, void_ptr_val, int64_t_val);
+ svstr_za(uint32_t_val, void_ptr_val);
+ svzero_mask_za(2);
+ svzero_za();
+}
diff --git a/clang/test/Sema/AArch64/arm_sme_streaming_compatible_sme_AND_sme2.c b/clang/test/Sema/AArch64/arm_sme_streaming_compatible_sme_AND_sme2.c
new file mode 100644
index 0000000000000..ea17ab9c6a5d0
--- /dev/null
+++ b/clang/test/Sema/AArch64/arm_sme_streaming_compatible_sme_AND_sme2.c
@@ -0,0 +1,33 @@
+// NOTE: File has been autogenerated by utils/aarch64_builtins_test_generator.py
+// RUN: %clang_cc1 %s -fsyntax-only -triple aarch64-none-linux-gnu -target-feature +sme -target-feature +sme2 -verify
+// expected-no-diagnostics
+
+// REQUIRES: aarch64-registered-target
+
+#include <arm_sme.h>
+
+// Properties: guard="" streaming_guard="sme,sme2" flags="streaming-compatible,requires-zt"
+
+void test(void) __arm_inout("zt0"){
+ void * void_ptr_val;
+
+ svldr_zt(0, void_ptr_val);
+ svstr_zt(0, void_ptr_val);
+ svzero_zt(0);
+}
+
+void test_streaming(void) __arm_streaming __arm_inout("zt0"){
+ void * void_ptr_val;
+
+ svldr_zt(0, void_ptr_val);
+ svstr_zt(0, void_ptr_val);
+ svzero_zt(0);
+}
+
+void test_streaming_compatible(void) __arm_streaming_compatible __arm_inout("zt0"){
+ void * void_ptr_val;
+
+ svldr_zt(0, void_ptr_val);
+ svstr_zt(0, void_ptr_val);
+ svzero_zt(0);
+}
diff --git a/clang/test/Sema/AArch64/arm_sme_streaming_only_sme.c b/clang/test/Sema/AArch64/arm_sme_streaming_only_sme.c
new file mode 100644
index 0000000000000..29bc3aab3f9c6
--- /dev/null
+++ b/clang/test/Sema/AArch64/arm_sme_streaming_only_sme.c
@@ -0,0 +1,1491 @@
+// NOTE: File has been autogenerated by utils/aarch64_builtins_test_generator.py
+// RUN: %clang_cc1 %s -fsyntax-only -triple aarch64-none-linux-gnu -target-feature +sme -target-feature +sve -verify=streaming-guard
+
+// REQUIRES: aarch64-registered-target
+
+#include <arm_sme.h>
+
+// Properties: guard="" streaming_guard="sme" flags="streaming-only,requires-za"
+
+void test(void) __arm_inout("za"){
+ int64_t int64_t_val;
+ svbfloat16_t svbfloat16_t_val;
+ svbool_t svbool_t_val;
+ svfloat16_t svfloat16_t_val;
+ svfloat32_t svfloat32_t_val;
+ svfloat64_t svfloat64_t_val;
+ svint8_t svint8_t_val;
+ svint16_t svint16_t_val;
+ svint32_t svint32_t_val;
+ svint64_t svint64_t_val;
+ svmfloat8_t svmfloat8_t_val;
+ svuint8_t svuint8_t_val;
+ svuint16_t svuint16_t_val;
+ svuint32_t svuint32_t_val;
+ svuint64_t svuint64_t_val;
+ uint32_t uint32_t_val;
+ void * void_ptr_val;
+
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svaddha_za32_m(2, svbool_t_val, svbool_t_val, svint32_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svaddha_za32_m(2, svbool_t_val, svbool_t_val, svuint32_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svaddha_za32_s32_m(2, svbool_t_val, svbool_t_val, svint32_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svaddha_za32_u32_m(2, svbool_t_val, svbool_t_val, svuint32_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svaddva_za32_m(2, svbool_t_val, svbool_t_val, svint32_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svaddva_za32_m(2, svbool_t_val, svbool_t_val, svuint32_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svaddva_za32_s32_m(2, svbool_t_val, svbool_t_val, svint32_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svaddva_za32_u32_m(2, svbool_t_val, svbool_t_val, svuint32_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svld1_hor_vnum_za8(0, uint32_t_val, svbool_t_val, void_ptr_val, int64_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svld1_hor_vnum_za16(1, uint32_t_val, svbool_t_val, void_ptr_val, int64_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svld1_hor_vnum_za32(2, uint32_t_val, svbool_t_val, void_ptr_val, int64_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svld1_hor_vnum_za64(2, uint32_t_val, svbool_t_val, void_ptr_val, int64_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svld1_hor_vnum_za128(2, uint32_t_val, svbool_t_val, void_ptr_val, int64_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svld1_hor_za8(0, uint32_t_val, svbool_t_val, void_ptr_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svld1_hor_za16(1, uint32_t_val, svbool_t_val, void_ptr_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svld1_hor_za32(2, uint32_t_val, svbool_t_val, void_ptr_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svld1_hor_za64(2, uint32_t_val, svbool_t_val, void_ptr_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svld1_hor_za128(2, uint32_t_val, svbool_t_val, void_ptr_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svld1_ver_vnum_za8(0, uint32_t_val, svbool_t_val, void_ptr_val, int64_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svld1_ver_vnum_za16(1, uint32_t_val, svbool_t_val, void_ptr_val, int64_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svld1_ver_vnum_za32(2, uint32_t_val, svbool_t_val, void_ptr_val, int64_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svld1_ver_vnum_za64(2, uint32_t_val, svbool_t_val, void_ptr_val, int64_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svld1_ver_vnum_za128(2, uint32_t_val, svbool_t_val, void_ptr_val, int64_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svld1_ver_za8(0, uint32_t_val, svbool_t_val, void_ptr_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svld1_ver_za16(1, uint32_t_val, svbool_t_val, void_ptr_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svld1_ver_za32(2, uint32_t_val, svbool_t_val, void_ptr_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svld1_ver_za64(2, uint32_t_val, svbool_t_val, void_ptr_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svld1_ver_za128(2, uint32_t_val, svbool_t_val, void_ptr_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svmopa_za32_bf16_m(2, svbool_t_val, svbool_t_val, svbfloat16_t_val, svbfloat16_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svmopa_za32_f16_m(2, svbool_t_val, svbool_t_val, svfloat16_t_val, svfloat16_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svmopa_za32_f32_m(2, svbool_t_val, svbool_t_val, svfloat32_t_val, svfloat32_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svmopa_za32_m(2, svbool_t_val, svbool_t_val, svbfloat16_t_val, svbfloat16_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svmopa_za32_m(2, svbool_t_val, svbool_t_val, svfloat16_t_val, svfloat16_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svmopa_za32_m(2, svbool_t_val, svbool_t_val, svfloat32_t_val, svfloat32_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svmopa_za32_m(2, svbool_t_val, svbool_t_val, svint8_t_val, svint8_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svmopa_za32_m(2, svbool_t_val, svbool_t_val, svuint8_t_val, svuint8_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svmopa_za32_s8_m(2, svbool_t_val, svbool_t_val, svint8_t_val, svint8_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svmopa_za32_u8_m(2, svbool_t_val, svbool_t_val, svuint8_t_val, svuint8_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svmops_za32_bf16_m(2, svbool_t_val, svbool_t_val, svbfloat16_t_val, svbfloat16_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svmops_za32_f16_m(2, svbool_t_val, svbool_t_val, svfloat16_t_val, svfloat16_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svmops_za32_f32_m(2, svbool_t_val, svbool_t_val, svfloat32_t_val, svfloat32_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svmops_za32_m(2, svbool_t_val, svbool_t_val, svbfloat16_t_val, svbfloat16_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svmops_za32_m(2, svbool_t_val, svbool_t_val, svfloat16_t_val, svfloat16_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svmops_za32_m(2, svbool_t_val, svbool_t_val, svfloat32_t_val, svfloat32_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svmops_za32_m(2, svbool_t_val, svbool_t_val, svint8_t_val, svint8_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svmops_za32_m(2, svbool_t_val, svbool_t_val, svuint8_t_val, svuint8_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svmops_za32_s8_m(2, svbool_t_val, svbool_t_val, svint8_t_val, svint8_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svmops_za32_u8_m(2, svbool_t_val, svbool_t_val, svuint8_t_val, svuint8_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svread_hor_za8_m(svint8_t_val, svbool_t_val, 0, uint32_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svread_hor_za8_m(svmfloat8_t_val, svbool_t_val, 0, uint32_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svread_hor_za8_m(svuint8_t_val, svbool_t_val, 0, uint32_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svread_hor_za8_mf8_m(svmfloat8_t_val, svbool_t_val, 0, uint32_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svread_hor_za8_s8_m(svint8_t_val, svbool_t_val, 0, uint32_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svread_hor_za8_u8_m(svuint8_t_val, svbool_t_val, 0, uint32_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svread_hor_za16_bf16_m(svbfloat16_t_val, svbool_t_val, 1, uint32_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svread_hor_za16_f16_m(svfloat16_t_val, svbool_t_val, 1, uint32_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svread_hor_za16_m(svbfloat16_t_val, svbool_t_val, 1, uint32_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svread_hor_za16_m(svfloat16_t_val, svbool_t_val, 1, uint32_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svread_hor_za16_m(svint16_t_val, svbool_t_val, 1, uint32_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svread_hor_za16_m(svuint16_t_val, svbool_t_val, 1, uint32_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svread_hor_za16_s16_m(svint16_t_val, svbool_t_val, 1, uint32_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svread_hor_za16_u16_m(svuint16_t_val, svbool_t_val, 1, uint32_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svread_hor_za32_f32_m(svfloat32_t_val, svbool_t_val, 2, uint32_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svread_hor_za32_m(svfloat32_t_val, svbool_t_val, 2, uint32_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svread_hor_za32_m(svint32_t_val, svbool_t_val, 2, uint32_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svread_hor_za32_m(svuint32_t_val, svbool_t_val, 2, uint32_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svread_hor_za32_s32_m(svint32_t_val, svbool_t_val, 2, uint32_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svread_hor_za32_u32_m(svuint32_t_val, svbool_t_val, 2, uint32_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svread_hor_za64_f64_m(svfloat64_t_val, svbool_t_val, 2, uint32_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svread_hor_za64_m(svfloat64_t_val, svbool_t_val, 2, uint32_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svread_hor_za64_m(svint64_t_val, svbool_t_val, 2, uint32_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svread_hor_za64_m(svuint64_t_val, svbool_t_val, 2, uint32_t_val);
+ // streaming-guard-error@+1 {{builtin can only be called from a streaming function}}
+ svread_hor_za64_s64_m(svint64_t_val, svbool_t_val, 2, uint32_t_val);
...
[truncated]
|
|
✅ With the latest revision this PR passed the Python code formatter. |
paulwalker-arm
force-pushed
the
sve-acle-test-refactor
branch
from
1d2952a to
418c118
Compare
huntergr-arm
reviewed
Sep 8, 2025
|
ping |
|
|
||
| def make_filename(prefix: str, ctx: BuiltinContext, ext: str) -> str: | ||
| parts = [sanitise_guard(ctx.guard), sanitise_guard(ctx.streaming_guard)] | ||
| sanitised_guard = "___".join(p for p in parts if p) |
There was a problem hiding this comment.
I think it would help to make the names a bit more readable if the sve & sme parts of the guard don't appear and are just separated by ___, similar to how the TargetGuards were changed recently?
For example:
arm_sve_feature_dependent_sve_AND_LP_sve2p1_OR_sme2_RP___sme_AND_LP_sve2p1_OR_sme2_RP.c
->
arm_sve_feature_dependent_sve2p1_OR_sme2___sve2p1_OR_sme2.c
Maybe it's not worth the extra complication here, so it's just a suggestion.
There was a problem hiding this comment.
I think that might be more confusing. There are tests that only use sve and/or sme where omitting them would look weird. I could keep them for those cases but then the naming will be inconsistent. There's also the small possibility that we'll have similar tests for the NEON instructions available in streaming mode, where we'll not want the non-streaming case to imply SVE is available.
Adds SEMA tests to verify correct SVE/SME builtin usage based on the calling function's type (i.e. normal, streaming or streaming compatible). For invalid uses the tests verify the expected diagnostic is emitted. This exposed an issue whereby some builtins are incorrectly callable by streaming compatible functions, which this PR fixes. The tests are autogenerated based on the builtin definitions (e.g. arm_sve.td). This is achieved by extending SVEEmitter, which can now emit a JSON file containing builtin usage information that can be fed to aarch64_builtins_test_generator.py that is also part of this PR.
paulwalker-arm
force-pushed
the
sve-acle-test-refactor
branch
from
f39b2c4 to
0269a02
Compare
| svsub_za16_f16_vg1x4(uint32_t_val, svfloat16x4_t_val); | ||
| svsub_za16_vg1x2(uint32_t_val, svfloat16x2_t_val); | ||
| svsub_za16_vg1x4(uint32_t_val, svfloat16x4_t_val); | ||
| } |
There was a problem hiding this comment.
Do tests which shouldn't result in a diagnostic need to be included by the script, since there should already be CodeGen tests elsewhere for all the builtins with the correct features?
(For example, this last builtin is tested in acle_sme2_add_sub_za16.c)
There was a problem hiding this comment.
Yes. My plan is to make the Sema tests (that are quick to run) exhaustively test feature flag combinations to ensure correct diagnostic behaviour. Once this is in place I can start reducing the number of RUN lines in the CodeGen tests (that are slow to run) to the minimum required to verify Clang is emitting the correct IR.
kmclaughlin-arm
approved these changes
Oct 3, 2025
There was a problem hiding this comment.
Thank you for answering my questions @paulwalker-arm, LGTM.
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/168/builds/16551 Here is the relevant piece of the build log for the reference |
svkeerthy
pushed a commit
that referenced
this pull request
Oct 9, 2025
Adds SEMA tests to verify correct SVE/SME builtin usage based on the calling function's type (i.e. normal, streaming or streaming compatible). For invalid uses the tests verify the expected diagnostic is emitted. This exposed an issue whereby some builtins are incorrectly callable by streaming compatible functions, which this PR fixes. The tests are autogenerated based on the builtin definitions (e.g. arm_sve.td). This is achieved by extending SVEEmitter, which can now emit a JSON file containing builtin usage information that can be fed to aarch64_builtins_test_generator.py that is also part of this PR. Everything currently in `clang/test/Sema/AArch64` is the result of: ``` clang/utils/aarch64_builtins_test_generator.py --gen-streaming-guard-tests <LLVM_BUILD_DIR>/tools/clang/include/clang/Basic/arm_sve_builtins.json --out-dir clang/test/Sema/AArch64/ clang/utils/aarch64_builtins_test_generator.py --gen-streaming-guard-tests <LLVM_BUILD_DIR>/tools/clang/include/clang/Basic/arm_sme_builtins.json --out-dir clang/test/Sema/AArch64/ ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds SEMA tests to verify correct SVE/SME builtin usage based on the calling function's type (i.e. normal, streaming or streaming compatible).
For invalid uses the tests verify the expected diagnostic is emitted. This exposed an issue whereby some builtins are incorrectly callable by streaming compatible functions, which this PR fixes.
The tests are autogenerated based on the builtin definitions (e.g. arm_sve.td). This is achieved by extending SVEEmitter, which can now emit a JSON file containing builtin usage information that can be fed to aarch64_builtins_test_generator.py that is also part of this PR.
Everything currently in
clang/test/Sema/AArch64is the result of: