Skip to content

[libc] Workaround for GCC on typedef for _Complex __float128 #157010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 5, 2025
Merged

[libc] Workaround for GCC on typedef for _Complex __float128 #157010

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9c7f53
[libc] Workaround for GCC on `typedef` for `_Complex __float128`
frederick-vs-ja Sep 5, 2025
45a99a0
Update comment for the GCC bug report, revert temporary change
frederick-vs-ja Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions libc/include/llvm-libc-types/cfloat128.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,12 @@

#ifdef LIBC_TYPES_HAS_CFLOAT128
#ifndef LIBC_TYPES_CFLOAT128_IS_COMPLEX_LONG_DOUBLE
#if defined(__GNUC__) && !defined(__clang__)
// Remove the workaround when https://gcc.gnu.org/PR121799 gets fixed.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was considered to be duplicate of https://gcc.gnu.org/PR32187 later. Will update the comment once it's confirmed the CI failure due to libc is fixed.

Suggested change
// Remove the workaround when https://gcc.gnu.org/PR121799 gets fixed.
// Remove the workaround when https://gcc.gnu.org/PR32187 gets fixed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. It can be confirmed that GCC is happy now. https://github.com/llvm/llvm-project/actions/runs/17483703784/job/49660001482

typedef __typeof__(_Complex __float128) cfloat128;
#else // ^^^ workaround / no workaround vvv
typedef _Complex __float128 cfloat128;
#endif // ^^^ workaround ^^^
#else
typedef _Complex long double cfloat128;
#endif // LIBC_TYPES_CFLOAT128_IS_COMPLEX_LONG_DOUBLE
Expand Down
2 changes: 2 additions & 0 deletions libcxx/include/__config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1265,3 +1265,5 @@ typedef __char32_t char32_t;
#endif // __cplusplus

#endif // _LIBCPP___CONFIG

// triggering CI, will be reverted
Loading