[Dexter] llvm-lit: always log DAP messages #157145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the Python code formatter. |
SLTozer
approved these changes
Sep 8, 2025
Contributor
SLTozer
left a comment
SLTozer
left a comment
There was a problem hiding this comment.
Seems like the most robust way to get information on the ongoing intermittent failures, SGTM.
OCHyams
added a commit
that referenced
this pull request
Sep 9, 2025
Reverts #157145 This was just temporary to help debug a flaky bot
OCHyams
added a commit
that referenced
this pull request
Sep 9, 2025
Buildbot cross-project-tests-sie-ubuntu has been unstable recently (https://lab.llvm.org/buildbot/#/builders/181). Dexter uses lldb-dap in these tests. Occasionally a one will fail with a KeyError because of a missing "stackFrames" "source" "path". I can't reproduce the failure locally, but with PRs #157130 and #157145 I've got DAP logs from a pass and fail. In a failure, "path" is missing for a step out of main (off the final brace), and the passing test has one additional "module" event for libc.so.6. ``` <- { "body": { "module": { "addressRange": "0x7ffff7dd1000", "debugInfoSize": "4.9MB", "id": "5792732F-7831-58C6-6FB4-F3756458CA24-E46E827D", "name": "libc.so.6", "path": "/lib/x86_64-linux-gnu/libc.so.6", "symbolFilePath": "/usr/lib/debug/.build-id/57/92732f783158c66fb4f3756458ca24e46e827d.debug", "symbolStatus": "Symbols loaded." }, "reason": "new" }, "event": "module", "seq": 0, "type": "event" } ``` That explains why we get a step that is missing a "path" component in the failure. I don't understand why LLDB (or LLDB-DAP) is sometimes unable to load the module (in time?). But "path" is an optional field anyway, so I think it's worth handling in dexter even if LLDB's behaviour here is confusing. This commit should stabilize the bot if the only time a module goes missing is for steps outside main. (Ideally none would go missing, but those shouldn't interfere with the tests).
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Sep 9, 2025
Reverts llvm/llvm-project#157145 This was just temporary to help debug a flaky bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #157090 description for motivation.
Printing the dap logs to stdout/err on failure sadly isn't enough (see #157130).
With this patch, we might be able to get clues about the flaky tests with well timed log inspection.