[PassBuilder] Add callback invoking to PassBuilder string API #157153
Conversation
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
gbaraldi
force-pushed
the
gb/opt-callbacks
branch
from
fa48915 to
a1320e3
Compare
llvm/lib/Passes/PassRegistry.def
Outdated
| #undef LOOP_PASS_WITH_PARAMS | ||
|
|
||
| #ifdef MODULE_CALLBACK | ||
| MODULE_CALLBACK("PipelineStartCallbacks", invokePipelineStartEPCallbacks) |
There was a problem hiding this comment.
nit: this doesn't follow naming conventions in this file for passes, this should probably be something like callbacks-pipeline-start
llvm/lib/Passes/PassBuilder.cpp
Outdated
| return true; \ | ||
| } | ||
| #include "PassRegistry.def" | ||
| #undef CGSCC_CALLBACK |
There was a problem hiding this comment.
the other macros are undefed in PassRegistry.def rather than here, why is this different?
There was a problem hiding this comment.
Oh, I hadn't seen that. I usually don't #define in one file and #undef in the other but following convention is fine
|
I don't have commit bit, so could someone commit for me :) |
Done, cheers Also I just saw:
here is the policy: https://llvm.org/docs/DeveloperPolicy.html#ai-generated-contributions |
3 participants
This is a very rough state of what this can look like, but I didn't want to spend too much time on what could be a dead end.
Currently the only way to invoke callbacks is by using the default pipelines, this is an issue if you want to define your own pipeline using the C string API (we do that in LLVM.jl in julia) so I extended the api to allow for invoking those callbacks just like one would call a pass of that kind.
There are some questions about the params that these callbacks take and also I'm missing some of them (some of them are also invoked by the backend so we may not want to expose them)
Code written with AI help, bugs are mine. (Not sure what policy for this is on LLVM)