- 
                Notifications
    
You must be signed in to change notification settings  - Fork 15.1k
 
[MC] Rewrite stdin.s to use python #157232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            boomanaiden154
  merged 13 commits into
  main
from
users/boomanaiden154/mc-invoke-run-line-in-stdins-using-bash
  
      
      
   
  Sep 9, 2025 
      
    
  
     Merged
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            13 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      5b8936b
              
                [𝘀𝗽𝗿] initial version
              
              
                boomanaiden154 4b43d2f
              
                [𝘀𝗽𝗿] changes to main this commit is based on
              
              
                boomanaiden154 d749f30
              
                feedback
              
              
                boomanaiden154 5c30009
              
                [𝘀𝗽𝗿] changes introduced through rebase
              
              
                boomanaiden154 e1e62f3
              
                rebase
              
              
                boomanaiden154 0bfe954
              
                feedback
              
              
                boomanaiden154 2ae17e4
              
                feedback
              
              
                boomanaiden154 f876f35
              
                [𝘀𝗽𝗿] changes introduced through rebase
              
              
                boomanaiden154 e4b8964
              
                rebase
              
              
                boomanaiden154 532428d
              
                [𝘀𝗽𝗿] changes introduced through rebase
              
              
                boomanaiden154 9083164
              
                rebase
              
              
                boomanaiden154 0e6bbc9
              
                [𝘀𝗽𝗿] changes introduced through rebase
              
              
                boomanaiden154 55c02a3
              
                fix
              
              
                boomanaiden154 File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| # RUN: echo "// comment" > %t.input | ||
| # We use STDIN to for the binary name as lit will substitute in the full path | ||
| # of the binary before executing, ensuring we pick up the correct llvm-mc. | ||
| # RUN: echo llvm-mc | %python %s %t.input %t | ||
| 
     | 
||
| import argparse | ||
| import subprocess | ||
| import sys | ||
| 
     | 
||
| parser = argparse.ArgumentParser() | ||
| parser.add_argument("input_file") | ||
| parser.add_argument("temp_file") | ||
| arguments = parser.parse_args() | ||
| 
     | 
||
| llvm_mc_binary = sys.stdin.readlines()[0].strip() | ||
| 
     | 
||
| with open(arguments.temp_file, "w") as mc_stdout: | ||
| ## We need to test that starting on an input stream with a non-zero offset | ||
| ## does not trigger an assertion in WinCOFFObjectWriter.cpp, so we seek | ||
| ## past zero for STDOUT. | ||
| mc_stdout.seek(4) | ||
| subprocess.run( | ||
| [ | ||
| llvm_mc_binary, | ||
| "-filetype=obj", | ||
| "-triple", | ||
| "i686-pc-win32", | ||
| arguments.input_file, | ||
| ], | ||
| stdout=mc_stdout, | ||
| check=True, | ||
| ) | ||
This file was deleted.
      
      Oops, something went wrong.
      
    
  
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Uh oh!
There was an error while loading. Please reload this page.