[CGData] Rewrite tests to not use subshells #157234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6 [skip ci]
Created using spr 1.3.6
Created using spr 1.3.6 [skip ci]
Created using spr 1.3.6 [skip ci]
Created using spr 1.3.6 [skip ci]
Created using spr 1.3.6 [skip ci]
petrhosek
approved these changes
Sep 9, 2025
boomanaiden154
changed the base branch from
users/boomanaiden154/main.cgdata-rewrite-tests-to-not-use-subshells
to
main
boomanaiden154
deleted the
users/boomanaiden154/cgdata-rewrite-tests-to-not-use-subshells
branch
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Sep 9, 2025
Subshells are not supported by lit's internal shell, which we want to enable by default for the LLVM test suite. Rewrite the tests in llvm/test/tools/llvm-cgdata to not use subshells so we can achieve this without losing any test coverage. Reviewers: kyulee-com, petrhosek, ilovepi Reviewed By: ilovepi, petrhosek Pull Request: llvm/llvm-project#157234
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subshells are not supported by lit's internal shell, which we want to
enable by default for the LLVM test suite. Rewrite the tests in
llvm/test/tools/llvm-cgdata to not use subshells so we can achieve this
without losing any test coverage.