Skip to content

[Support] Simplify Object::operator== (NFC) #157311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2025
Merged

[Support] Simplify Object::operator== (NFC) #157311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions llvm/include/llvm/Support/JSON.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,8 @@ class Object {
LLVM_ABI json::Object *getObject(StringRef K);
LLVM_ABI const json::Array *getArray(StringRef K) const;
LLVM_ABI json::Array *getArray(StringRef K);

friend bool operator==(const Object &LHS, const Object &RHS);
};
LLVM_ABI bool operator==(const Object &LHS, const Object &RHS);
inline bool operator!=(const Object &LHS, const Object &RHS) {
Expand Down
11 changes: 1 addition & 10 deletions llvm/lib/Support/JSON.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,16 +84,7 @@ json::Array *Object::getArray(StringRef K) {
return V->getAsArray();
return nullptr;
}
bool operator==(const Object &LHS, const Object &RHS) {
if (LHS.size() != RHS.size())
return false;
for (const auto &L : LHS) {
auto R = RHS.find(L.first);
if (R == RHS.end() || L.second != R->second)
return false;
}
return true;
}
bool operator==(const Object &LHS, const Object &RHS) { return LHS.M == RHS.M; }

Array::Array(std::initializer_list<Value> Elements) {
V.reserve(Elements.size());
Expand Down