Skip to content

[llvm] Validate Parent object before dereference #157460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 17, 2025
Merged

[llvm] Validate Parent object before dereference #157460

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2894721
[llvm] Validate Parent object before dereference
apach301 Sep 8, 2025
29d1ade
Fix linter error
apach301 Sep 9, 2025
ec4a38f
Remove redunant assert as Parent is always non-null
apach301 Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions llvm/lib/Object/Archive.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,10 +472,10 @@ Archive::Child::Child(const Archive *Parent, const char *Start, Error *Err)
return;
}

assert(Parent && "Parent can't be nullptr if Start is not a nullptr");

Header = Parent->createArchiveMemberHeader(
Start,
Parent ? Parent->getData().size() - (Start - Parent->getData().data())
: 0,
Start, Parent->getData().size() - (Start - Parent->getData().data()),
Err);

// If we are pointed to real data, Start is not a nullptr, then there must be
Expand Down