Skip to content

[Xtensa] Fix lowering FP compare operations. #157520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tru merged 1 commit into from
Sep 9, 2025
Merged

[Xtensa] Fix lowering FP compare operations. #157520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions llvm/lib/Target/Xtensa/XtensaISelLowering.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,12 +232,6 @@ XtensaTargetLowering::XtensaTargetLowering(const TargetMachine &TM,
setOperationAction(ISD::SINT_TO_FP, MVT::i32, Legal);
setOperationAction(ISD::FP_TO_UINT, MVT::i32, Legal);
setOperationAction(ISD::FP_TO_SINT, MVT::i32, Legal);

setCondCodeAction(ISD::SETOGT, MVT::f32, Expand);
setCondCodeAction(ISD::SETOGE, MVT::f32, Expand);
setCondCodeAction(ISD::SETONE, MVT::f32, Expand);
setCondCodeAction(ISD::SETUGE, MVT::f32, Expand);
setCondCodeAction(ISD::SETUGT, MVT::f32, Expand);
} else {
setOperationAction(ISD::BITCAST, MVT::i32, Expand);
setOperationAction(ISD::BITCAST, MVT::f32, Expand);
Expand Down Expand Up @@ -877,6 +871,16 @@ static std::pair<unsigned, unsigned> getFPBranchKind(ISD::CondCode Cond) {
return std::make_pair(Xtensa::BF, Xtensa::OLT_S);
case ISD::SETGT:
return std::make_pair(Xtensa::BF, Xtensa::OLE_S);
case ISD::SETOGT:
return std::make_pair(Xtensa::BF, Xtensa::ULE_S);
case ISD::SETOGE:
return std::make_pair(Xtensa::BF, Xtensa::ULT_S);
case ISD::SETONE:
return std::make_pair(Xtensa::BF, Xtensa::UEQ_S);
case ISD::SETUGT:
return std::make_pair(Xtensa::BF, Xtensa::OLE_S);
case ISD::SETUGE:
return std::make_pair(Xtensa::BF, Xtensa::OLT_S);
default:
llvm_unreachable("Invalid condition!");
}
Expand Down
33 changes: 24 additions & 9 deletions llvm/test/CodeGen/Xtensa/select-cc-fp.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,8 @@ define float @brcc_olt(float %a, float %b) nounwind {
; CHECK: # %bb.0:
; CHECK-NEXT: wfr f8, a3
; CHECK-NEXT: wfr f9, a2
; CHECK-NEXT: ule.s b0, f8, f9
; CHECK-NEXT: bt b0, .LBB3_2
; CHECK-NEXT: olt.s b0, f9, f8
; CHECK-NEXT: bf b0, .LBB3_2
; CHECK-NEXT: # %bb.1: # %t1
; CHECK-NEXT: l32r a8, .LCPI3_1
; CHECK-NEXT: wfr f8, a8
Expand Down Expand Up @@ -135,8 +135,8 @@ define float @brcc_ole(float %a, float %b) nounwind {
; CHECK: # %bb.0:
; CHECK-NEXT: wfr f8, a3
; CHECK-NEXT: wfr f9, a2
; CHECK-NEXT: ult.s b0, f8, f9
; CHECK-NEXT: bt b0, .LBB4_2
; CHECK-NEXT: ole.s b0, f9, f8
; CHECK-NEXT: bf b0, .LBB4_2
; CHECK-NEXT: # %bb.1: # %t1
; CHECK-NEXT: l32r a8, .LCPI4_1
; CHECK-NEXT: wfr f8, a8
Expand Down Expand Up @@ -232,7 +232,7 @@ define float @brcc_ueq(float %a, float %b) nounwind {
; CHECK-NEXT: wfr f8, a3
; CHECK-NEXT: wfr f9, a2
; CHECK-NEXT: ueq.s b0, f9, f8
; CHECK-NEXT: bt b0, .LBB7_2
; CHECK-NEXT: bf b0, .LBB7_2
; CHECK-NEXT: # %bb.1: # %t1
; CHECK-NEXT: l32r a8, .LCPI7_1
; CHECK-NEXT: wfr f8, a8
Expand Down Expand Up @@ -327,8 +327,8 @@ define float @brcc_ult(float %a, float %b) nounwind {
; CHECK: # %bb.0:
; CHECK-NEXT: wfr f8, a3
; CHECK-NEXT: wfr f9, a2
; CHECK-NEXT: ole.s b0, f8, f9
; CHECK-NEXT: bt b0, .LBB10_2
; CHECK-NEXT: ult.s b0, f9, f8
; CHECK-NEXT: bf b0, .LBB10_2
; CHECK-NEXT: # %bb.1: # %t1
; CHECK-NEXT: l32r a8, .LCPI10_1
; CHECK-NEXT: wfr f8, a8
Expand Down Expand Up @@ -359,8 +359,8 @@ define float @brcc_ule(float %a, float %b) nounwind {
; CHECK: # %bb.0:
; CHECK-NEXT: wfr f8, a3
; CHECK-NEXT: wfr f9, a2
; CHECK-NEXT: olt.s b0, f8, f9
; CHECK-NEXT: bt b0, .LBB11_2
; CHECK-NEXT: ule.s b0, f9, f8
; CHECK-NEXT: bf b0, .LBB11_2
; CHECK-NEXT: # %bb.1: # %t1
; CHECK-NEXT: l32r a8, .LCPI11_1
; CHECK-NEXT: wfr f8, a8
Expand Down Expand Up @@ -451,6 +451,21 @@ exit:
}

define float @copysign_f32(float %a, float %b) {
; CHECK-LABEL: copysign_f32:
; CHECK: .cfi_startproc
; CHECK-NEXT: # %bb.0: # %entry
; CHECK-NEXT: l32r a8, .LCPI14_0
; CHECK-NEXT: and a8, a3, a8
; CHECK-NEXT: l32r a9, .LCPI14_1
; CHECK-NEXT: and a9, a2, a9
; CHECK-NEXT: wfr f8, a9
; CHECK-NEXT: movi a9, 0
; CHECK-NEXT: beq a8, a9, .LBB14_2
; CHECK-NEXT: # %bb.1:
; CHECK-NEXT: neg.s f8, f8
; CHECK-NEXT: .LBB14_2: # %entry
; CHECK-NEXT: rfr a2, f8
; CHECK-NEXT: ret
entry:
%c = call float @llvm.copysign.f32(float %a, float %b)
ret float %c
Expand Down
Loading