Skip to content

[RISCV] Support umin/umax in tryFoldSelectIntoOp #157548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 12, 2025
Merged

[RISCV] Support umin/umax in tryFoldSelectIntoOp #157548

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5417701
[RISCV] Add coverage for select with minmax arm [nfc]
preames Sep 8, 2025
2fcbd33
Merge branch 'main' into wip-riscv-select-umin-umax
preames Sep 8, 2025
79573fa
[RISCV] Support umin/umax in tryFoldSelectIntoOp
preames Sep 8, 2025
973fe66
Merge branch 'main' into pr-riscv-select-umin-umax
preames Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions llvm/lib/Target/RISCV/RISCVISelLowering.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18835,6 +18835,8 @@ static SDValue tryFoldSelectIntoOp(SDNode *N, SelectionDAG &DAG,
case ISD::ADD:
case ISD::OR:
case ISD::XOR:
case ISD::UMIN:
case ISD::UMAX:
Comment on lines +18838 to +18839
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think SMAX/SMIN would also be good to add, and yield similar results?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mentioned in the description "smin/smax are a bit harder, and will be a separate change."

break;
}

Expand Down
Loading
Loading