Skip to content

[NFC][LLVM] Namespace cleanup in MetadataLoader.cpp #157595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2025
Merged

[NFC][LLVM] Namespace cleanup in MetadataLoader.cpp #157595

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3cba717
[NFC][LLVM] Namespace cleanup in MetadataLoader.cpp
jurahul Sep 9, 2025
a9eb98d
Review feedback
jurahul Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions llvm/lib/Bitcode/Reader/MetadataLoader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,6 @@
#include <tuple>
#include <utility>
#include <vector>
namespace llvm {
class Argument;
}

using namespace llvm;

Expand All @@ -83,8 +80,6 @@ static cl::opt<bool> DisableLazyLoading(

namespace {

static int64_t unrotateSign(uint64_t U) { return (U & 1) ? ~(U >> 1) : U >> 1; }

class BitcodeReaderMetadataList {
/// Array of metadata references.
///
Expand Down Expand Up @@ -129,10 +124,7 @@ class BitcodeReaderMetadataList {
void pop_back() { MetadataPtrs.pop_back(); }
bool empty() const { return MetadataPtrs.empty(); }

Metadata *operator[](unsigned i) const {
assert(i < MetadataPtrs.size());
return MetadataPtrs[i];
}
Metadata *operator[](unsigned i) const { return MetadataPtrs[i]; }

Metadata *lookup(unsigned I) const {
if (I < MetadataPtrs.size())
Expand Down Expand Up @@ -178,6 +170,9 @@ class BitcodeReaderMetadataList {
private:
Metadata *resolveTypeRefArray(Metadata *MaybeTuple);
};
} // namespace

static int64_t unrotateSign(uint64_t U) { return (U & 1) ? ~(U >> 1) : U >> 1; }

void BitcodeReaderMetadataList::assignValue(Metadata *MD, unsigned Idx) {
if (auto *MDN = dyn_cast<MDNode>(MD))
Expand Down Expand Up @@ -392,8 +387,6 @@ void PlaceholderQueue::flush(BitcodeReaderMetadataList &MetadataList) {
}
}

} // anonymous namespace

static Error error(const Twine &Message) {
return make_error<StringError>(
Message, make_error_code(BitcodeError::CorruptedBitcode));
Expand Down